Fix go modules when not using proxy.golang.org #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix bad commit hash for che plugin broker (and update to latest released version -- v3.4.0) * Fix openshift/api dependency that was broken by the repo removing tags (updated to current latest) Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
When a workspace is created with openshift-oauth routing in a kubernetes cluster, the controller will try to reconcile OAuthClients, which do not exist as a resource on k8s. This causes a reconcile loop when attempting to remove a WorkspaceRouting, as the finalizer cannot be removed since deleting OAuthClients will return an error. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
sleshchenko
approved these changes
Oct 1, 2020
JPinkney
approved these changes
Oct 1, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates dependencies to resolve a few issues:
che-plugin-brokerto versionv3.4.0, since the previous commit we relied on is not in any branch in the repo.This PR also includes to minor fixups I needed to implement to get things working on k8s:
controller.yamlwhen usingkubectlopenshift-oauthrouting on kubernetes. Doing so caused workspaceRoutings to never have their finalizer removed and the controller to loop on an error.What issues does this PR fix or reference?
#166
Is it tested? How?
Tested on
minikube