WIP Change default namespace to openshift-operators #275
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -17,7 +17,7 @@ ifndef VERBOSE | |||
| MAKEFLAGS += --silent | |||
| endif | |||
|
|
|||
| export NAMESPACE ?= devworkspace-controller | |||
| export NAMESPACE ?= openshift-operators | |||
There was a problem hiding this comment.
If it makes any sense we can stick to devworkspace-controller for development, but after chectl depends on it, I think it makes sense to unify default.
There was a problem hiding this comment.
marked as WIP since if openshift-operator is the default, then we must not remove that namespace on uninstall
sleshchenko
force-pushed
the
new-default-namespace
branch
from
f4adde4
to
e566920
Compare
|
what will happen on pure kubernetes? |
sleshchenko
changed the title
It's such a good catch! |
| @@ -69,7 +69,7 @@ done | |||
|
|
|||
| if $USE_DEFAULT_ENV; then | |||
| echo "Using defaults for environment variables" | |||
| export NAMESPACE=devworkspace-controller | |||
| export NAMESPACE=openshift-operators | |||
There was a problem hiding this comment.
IMO this is the only change that should be made; the namespace in the Makefile will be ignored when the deployment/deploy templates are generated anyways.
There was a problem hiding this comment.
I would argue on that.
I mean I would be happy if we can reuse Makefile to work with deployment run with chectl. And Makefile reuse NAMESPACE from there to restart deployments at least.
But as we discussed on standup, probably we should stick to devworkspace-controller namespace as only available, that would work for K8s and Openshift and easier to clean up.
There was a problem hiding this comment.
Using the Makefile in chectl means having chectl depend on make, which is a strange choice. If we need a development version of DWO to run with Che, it should be deployed manually from our repo.
There was a problem hiding this comment.
I meant you deploy it with chectl, but then you need to update/debug DevWorkpaceOperator with makefile.
if we unify values, it would be possible to deploy/update in any case you like.
|
Closing since we think it's better to stick to devworkspace-operator or any other value that works for K8s and OpenShift + easy to clean up by removing the whole namespace. |
What does this PR do?
This PR changes default namespace to openshift-operators.
I did it since chectl start depends on our default namespace.
Because patching namespace on chectl side is tricky part, since it's needed to be updated in Certificate, CRDs annotations, CRDs spec, RoleBinding.
And I think openshift-operators is a better option, since it's always
all-cluster watching + WTO supports only it.
So, potentially chectl can rely on WTO objects(if they already are created) if it's updated to v1alpha2.
So, we have less conflicts.
What issues does this PR fix or reference?
It's related to che-incubator/chectl#1100 (comment)
Is it tested? How?
Not yet but changes are simple