Increase memoryLimit on PVC cleanup job to prevent failures #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting a too-low memory limit on pods can cause the pod to fail to be created on the cluster. This results in failures to delete DevWorkspaces that use storage, as the cleanup job can never complete. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
Testing the memoryLimit directly using the spec: apiVersion: v1
kind: Pod
metadata:
name: "test"
labels:
app: test
spec:
containers:
- image: quay.io/fedora/fedora:34
name: test
volumeMounts:
- mountPath: /tmp/claim-devworkspace
name: claim-devworkspace
command: ["tail"]
args: ["-f", "/dev/null"]
resources:
limits:
memory: 100Mi
volumes:
- name: claim-devworkspace
persistentVolumeClaim:
claimName: claim-devworkspace I see failures when the memory limit is |
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
/test v5-devworkspaces-operator-e2e |
sleshchenko
approved these changes
Mar 9, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merging but @JPinkney feel free to provide feedback if any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is kind of a shot in the dark for resolving #301: after some searching, there's a few bugzillas suggesting that the process being used to create the pod might be bumping into the memory limit (e.g. here). I've increased the memoryLimit to 100Mi and tested a few times on one of the clusters that reproduces the issue consistently and did not see it.
Please test thoroughly to make sure this fixes the problem.
What issues does this PR fix or reference?
Fixes #301
Is it tested? How?
samples/flattened_theia-next.yamltheiadevworkspace and make sure job completes successfully, finalizer is cleared.