Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade k8s api to v0.21.3 #109

Merged
merged 2 commits into from
Aug 12, 2021
Merged

upgrade k8s api to v0.21.3 #109

merged 2 commits into from
Aug 12, 2021

Conversation

sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Jul 26, 2021

What does this PR do?:

upgrade k8s api to v0.20.6 v0.21.3 which is version used by devfile/api after devfile/api#565

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

Update k8s dependencies to match controller-runtime v0.9.5:
* controller-runtime to v0.9.5
* k8s api/apimachinery/etc. to v0.21.3 (also used by DevWorkspace
  Operator)
* related dependencies to match rest of set
@openshift-ci openshift-ci bot removed the lgtm label Aug 11, 2021
@amisevsk amisevsk changed the title upgrade k8s api to v0.20.6 upgrade k8s api to v0.21.3 Aug 11, 2021
@amisevsk
Copy link
Collaborator

Updated to k8s v0.21.3 (so that all devfile projects end up in something resembling alignment. v0.21.3 is the k8s api version used for controller-runtime and controller-tools.

@maysunfaisal
Copy link
Member

@amisevsk seems like go mod tidy is failing

@sleshchenko
Copy link
Member Author

That's not really go.mod or go.sum state but seems dependency is incompatible with the current go version the project declares. So, upgrading to 1.15, let us know if you have any concerns about it

@sleshchenko sleshchenko requested review from maysunfaisal and removed request for maysunfaisal August 12, 2021 10:19
@openshift-ci openshift-ci bot added the lgtm label Aug 12, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, sleshchenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal merged commit a86fbb6 into main Aug 12, 2021
@amisevsk amisevsk deleted the updateK8sAPI branch August 12, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants