Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade k8s api to v0.21.3 #565

Merged
merged 3 commits into from
Aug 12, 2021
Merged

upgrade k8s api to v0.21.3 #565

merged 3 commits into from
Aug 12, 2021

Conversation

sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Jul 26, 2021

What does this PR do?:

upgrade k8s api to v0.20.6 v0.21.3, which is the version used by the latest release of controller-tools and thus also the DevWorkspace Operator.

related PR on devfile/library side devfile/library#109

Which issue(s) this PR fixes:

it's made in the scope of devfile/devworkspace-operator#516

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

@amisevsk
Copy link
Contributor

Updated dependencies to match what's used in controller-runtime v0.9.5`, i.e. k8s api v0.21.3.

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I've now worked on the PR

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, JPinkney, sleshchenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Update:
* controller-runtime dependency to v0.9.5
* k8s api/apimachinery/etc to v0.21.3
* controller-tools to v0.6.2 (matching k8s v0.21.3)

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants