Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player drops too early #60

Closed
tooxo opened this issue Aug 15, 2024 · 1 comment
Closed

Player drops too early #60

tooxo opened this issue Aug 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tooxo
Copy link
Contributor

tooxo commented Aug 15, 2024

In https://github.com/devgianlu/go-librespot/blob/master/player/player.go#L142 , the output is instructed to drop all queued frames, resulting in the end of the song missing, when one song goes over to the next without skipping.

My proposed solution: Only drop the frames, when the set command resulted from a skip and not a song regularly ending.
Alternative solution, if the above is not possible: Only drop the frames, when there is no secondary source configured. This would result in delayed skipping, if the song is in its last 30 seconds or so.

@devgianlu devgianlu added the bug Something isn't working label Aug 17, 2024
@devgianlu
Copy link
Owner

Opted for the first solution.

tooxo pushed a commit to tooxo/go-librespot that referenced this issue Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants