Skip to content

Commit

Permalink
Revert "[Performance] Ship ES6 code to production, drop IE support"
Browse files Browse the repository at this point in the history
This reverts commit 448d096.

Getting some "ReferenceError: Cannot access 'VARIABLE_NAME' before initialization" way too often.
  • Loading branch information
brunolemos committed Apr 15, 2019
1 parent 448d096 commit f3ee8a1
Show file tree
Hide file tree
Showing 8 changed files with 2,120 additions and 1,548 deletions.
3 changes: 0 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@
"tslint-react": "3.6.0",
"typescript": "3.3.4000"
},
"resolutions": {
"metro-react-native-babel-preset": "0.53.1"
},
"husky": {
"hooks": {
"pre-commit": "yarn workspace @devhub/desktop compile && lint-staged"
Expand Down
3 changes: 2 additions & 1 deletion packages/components/src/libs/bugsnag/index.web.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@ import bugsnagReact from '@bugsnag/plugin-react'
import _ from 'lodash'
import React from 'react'

import { appVersion } from '../../components/common/AppVersion'
import { BugnsagCrossPlatform } from './'
import { hideTokenFromString } from './index.shared'
// import { overrideConsoleError } from './index.shared'

const client = bugsnagJS({
apiKey: '231f337f6090422c611017d3dab3d32e',
appVersion: '0.48.1',
appVersion,
autoBreadcrumbs: true,
notifyReleaseStages: ['production'],
})
Expand Down
4 changes: 2 additions & 2 deletions packages/mobile/ios/devhub.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1703,7 +1703,7 @@
"$(SRCROOT)/../../../node_modules/bugsnag-react-native/cocoa/**",
);
INFOPLIST_FILE = devhub/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.4;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
OTHER_LDFLAGS = (
"$(inherited)",
Expand Down Expand Up @@ -1744,7 +1744,7 @@
"$(SRCROOT)/../../../node_modules/bugsnag-react-native/cocoa/**",
);
INFOPLIST_FILE = devhub/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.4;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
OTHER_LDFLAGS = (
"$(inherited)",
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"format": "prettier --write '{.,src/**}/*.{js,jsx,ts,tsx}'",
"lint": "tslint -p .",
"prepare": "cd .. && yarn patch-package",
"start": "node ../../node_modules/react-native/local-cli/cli.js start --projectRoot ../../",
"start": "node ../../node_modules/react-native/local-cli/cli.js start",
"studio": "open -a /Applications/Android\\ Studio.app ./android/",
"test": "jest",
"tsc": "tsc -b",
Expand Down
17 changes: 8 additions & 9 deletions packages/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,16 @@
"test": "react-app-rewired test"
},
"dependencies": {
"@babel/polyfill": "7.4.0",
"@devhub/components": "0.48.1",
"react": "16.8.6",
"react-app-polyfill": "1.0.0-next.b0cbf2ca",
"react-app-polyfill": "0.2.2",
"react-art": "16.8.6",
"react-dom": "16.8.6",
"react-native-web": "0.11.1",
"react-scripts": "3.0.0-next.b0cbf2ca",
"react-scripts": "2.1.8",
"resize-observer-polyfill": "1.5.1",
"smoothscroll-polyfill": "0.4.4"
"smoothscroll-polyfill": "0.4.3"
},
"devDependencies": {
"@types/jest": "24.0.11",
Expand All @@ -47,11 +48,9 @@
"webpack-bundle-analyzer": "3.1.0"
},
"browserslist": [
"last 2 Chrome versions",
"last 2 Firefox versions",
"last 1 Safari versions",
"last 1 Opera versions",
"last 1 iOS major versions",
"last 1 Android major versions"
">0.2%",
"not dead",
"not ie <= 9",
"not op_mini all"
]
}
2 changes: 2 additions & 0 deletions packages/web/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
throw error
}

import '@babel/polyfill'
import 'react-app-polyfill/ie9'
import 'resize-observer-polyfill/dist/ResizeObserver.global'
import smoothscroll from 'smoothscroll-polyfill'
smoothscroll.polyfill()
Expand Down
22 changes: 0 additions & 22 deletions patches/metro-react-native-babel-preset+0.53.1.patch

This file was deleted.

0 comments on commit f3ee8a1

Please sign in to comment.