[Swift 2.3] Fix crash for looking up sim id on real device #61
Conversation
kdawgwilk
changed the title
|
Hold off on this...I thought it was the force unwrap causing the crash but it appears to be the |
|
Alright this is ready to go. I found a better API to get the ENV var for the simulator that won't crash if it doesn't exist. and I give a default "Unknown" value as the identifier because I tried the identifier passed in but it caused and infinite recursion :( |
|
Hi, this one looks just as good as the Swift 3 one, however it doesn't build because line length is now 162 instead of 160 (this is an issue coming from our swiftlint rules. 2 possible fixes: change the rule in .swiftlint.yml or split the statement over multiple lines (I'd prefer the latter). Other than that: 💯🎉🙏 :) |
| case "i386", "x86_64": return Simulator(mapIdentifierToDevice(String(UTF8String: getenv("SIMULATOR_MODEL_IDENTIFIER"))!)) | ||
| case "i386", "x86_64": return Simulator(mapIdentifierToDevice( | ||
| NSProcessInfo().environment["SIMULATOR_MODEL_IDENTIFIER"] ?? "iOS" | ||
| )) |
There was a problem hiding this comment.
It looks weird here in the diff but it should look alright in Xcode
|
Looks like CI flaked out here as well? |
|
Perfect, thank you so much! :) |
This fixes a crash when trying to lookup a simulator identifier on a real device. Fixes Issue #60