Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift 3.0] Fix crash for looking up sim id on real device #62

Merged
merged 5 commits into from
Jan 5, 2017
Merged

[Swift 3.0] Fix crash for looking up sim id on real device #62

merged 5 commits into from
Jan 5, 2017

Conversation

kdawgwilk
Copy link
Contributor

This fixes a crash when trying to lookup a simulator identifier on a real device. Fixes Issue #60

@kdawgwilk
Copy link
Contributor Author

Alright this is ready to go. I found a better API to get the ENV var for the simulator that won't crash if it doesn't exist. and I give a default "Unknown" value as the identifier because I tried the identifier passed in but it caused and infinite recursion :(

@dennisweissmann
Copy link
Collaborator

Hi @kdagwilk! Thank you so much for exploring and solving this! This is so much nicer (and obviously better) 💯. One small thing: this code doesn't compile (during the transition to Swift 3 we lowercased the enum cases, so it should be simulator (with a small "s"). If you could fix that and then CI hopefully passes, I will merge it :) thanks so much 🙏 This is awesome 👏 🎉

@dennisweissmann
Copy link
Collaborator

My comment from #61 applies here too, I think :( sorry for the trouble!

@kdawgwilk
Copy link
Contributor Author

kdawgwilk commented Jan 5, 2017

It looks like it failed on a few sims but is succeeding everywhere else :( Anything I need to do on my end or is it just CI being flakey?

@dennisweissmann
Copy link
Collaborator

😔 sigh ... it's been ultra flaky for a few months now, LGTM, thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants