Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort entries in devicon.json alphabetically #1090

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

jusuchin85
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

During contributions, I noticed that the contents of the devicon.json file are not alphabetical. This is a PR to fix that. Hopefully, it'll be something that makes future contributions easier and more straightforward.

This PR closes NONE

Notes

  • Any existing PRs prior to this would need to be rebased after merge.
  • I'm not sure of the impact on any Actions. Need confirmation.

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no issues with the actions. I think the only problem is the PR having to rebase but that's about it.

@Thomas-Boi
Copy link
Member

There should be no issues with the actions. I think the only problem is the PR having to rebase but that's about it.

@Thomas-Boi Thomas-Boi merged commit a755bc9 into devicons:develop Mar 23, 2022
@jusuchin85 jusuchin85 deleted the reorder-devicon-json branch March 23, 2022 20:11
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants