Feature/convert style elements to attributes #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I have no rights here :( so somebody else has to approve |
|
Oh, I thought you had perms here too. Thanks for the review either way @maltejur , I will wait for someone else to review then :) |
amacado
approved these changes
Jul 22, 2022
Snailedlt
added a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* remove empty style attributes * fix ballerina icons
Snailedlt
added a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* remove empty style attributes * fix ballerina icons
Snailedlt
added a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* remove empty style attributes * fix ballerina icons
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
Features
This PR closes NONE
Notes
Converted Style tags into attributes, for better compatability with devicons/react-devicons. Also removed some unused style elements