Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/convert style elements to attributes #1276

Conversation

Snailedlt
Copy link
Collaborator

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

This PR closes NONE

Notes

Converted Style tags into attributes, for better compatability with devicons/react-devicons. Also removed some unused style elements

Copy link
Contributor

@maltejur maltejur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@maltejur
Copy link
Contributor

I have no rights here :( so somebody else has to approve

@Snailedlt
Copy link
Collaborator Author

Oh, I thought you had perms here too. Thanks for the review either way @maltejur , I will wait for someone else to review then :)

@amacado amacado merged commit 637a241 into devicons:develop Jul 22, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* remove empty style attributes

* fix ballerina icons
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* remove empty style attributes

* fix ballerina icons
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* remove empty style attributes

* fix ballerina icons
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants