new icon: matplotlib (original, original-wordmark, plain, plain-wordmark)

[BenSouchet]

Double check these details before you open a PR

• PR does not match another non-stale PR currently opened
• PR name matches the format new icon: Icon name (versions separated by comma). More details here
• PR's base is the develop branch.
• Your icons are inside a folder as seen here
• SVG matches the standards laid out here
• A new object is added in the devicon.json file as seen here

This PR closes #859

Link to prove your SVG is correct and up-to-date.

https://github.com/matplotlib/matplotlib

[github-actions]

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'matplotlib-original.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.

SVG Error in 'matplotlib-original-wordmark.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

[BenSouchet]

@Panquesito7 Since the original icons won't be used in icomoon can you skip the error ?
Because converting the dotted stroke will increase a lot the SVG files for no benefices.

[Panquesito7]

Hey there! Could you please fix the issues mentioned by the bot? Let us know if you need any help with that! Thank you for your contribution. 😃

__
 Summary: 🛠️ This code needs a fix  |  Tags: Inefficient

[BenSouchet]

@Panquesito7 Like I said in my previous message:

Since the original icons won't be used in icomoon can you skip / ignore the error ?
Because converting the dotted stroke will increase a lot the SVG files for no benefices.

[Panquesito7]

@Panquesito7 Since the original icons won't be used in icomoon can you skip the error ? Because converting the dotted stroke will increase a lot the SVG files for no benefices.

Hey! Not sure if we can actually skip that error. I think we should still follow these rules.
@Snailedlt, what do you think we should do here?

[BenSouchet]

This test exists because icomoon can't handle strokes but these two original icons won't be used by icomoon.

The check (Bot) should ignore the original versions if plain versions exists.

[Snailedlt]

@Panquesito7 I think what @BenSouchet is saying makes sense, but I'm a bit afraid to vouch for it since I don't know the intricacies.

We can try with peek:bot, if it still looks okey after that imo, we can merge. Then we'll just keep an eye out for that icon, and revert if it causes any issues :)

[Snailedlt]

The paths for plain versions should be merged into one, other than that it looks good :)

[BenSouchet]

The paths for plain versions should be merged into one, other than that it looks good :)

Okay, I optimized the paths :)

[github-actions]

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'matplotlib-original.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.

SVG Error in 'matplotlib-original-wordmark.svg':
- SVG contains `stroke` property. This will get ignored by Icomoon. Please convert them to fills.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

[Snailedlt]

Still multiple paths. Everything else looks good as far as I can tell

[Snailedlt]

Still multiple paths here. You can try using SVGOMG or this SVG optimizer -> https://www.ofoct.com/image-converter/svg-optimizer.html.
Both websites have a merge Paths option

[BenSouchet]

I do not understand why the fact the SVG as multiple paths is an issue, lots of SVG have multiple paths, even for plain version of icon / logo.

I don't think reducing to one path will improve the file size a lot, and it will complicate things if changes need to be made on the SVG afterwards.

And for info, for these SVG files, even using the links you shared you won't be able to reduce the number of path since these paths cannot be merge (at least with my knowledge and understanding of the SVG specification).

Last point, icomoon when importing SVGs will convert them to font glyph so the number of paths doesn't matter.

[Snailedlt]

I'm not sure what the exact reasoning for joining paths is either, but I am trying to enforce it because it is a part of the SVG Standards

The plain and line versions (with or without wordmark) need to stay as simple as possible. They must have only one color and the paths are united.

Maybe @Panquesito7 could tell us more about why that is, so we can update the wiki with more info (or remove it if it's not needed).

As for merging the paths, you're right. Doesn't work because the last path starts with m instead of M. It should still be possible in Inkscape though. I gave it a try and almost got there with this

almost identical, but the lines from the radar circle thingy are cutting through in some places

Here's both after eachother for comparison

[BenSouchet]

Yes the result of the "merge" give incorrect result and like I said the file size won't decrease, in fact the version you get is 3KB (25%) heavier than the one I created (with multiple paths)

[BenSouchet]

Having few / fewer paths is, lot of the time a good idea, but wanting to optimize more than what you can get with svg optimizers (like SVG Viewer or SVGOMG) won't give you the expected result or will create unstable files

[Snailedlt]

@BenSouchet Alright, I think I got the paths merged so that it's identical now:

New

Old

New & Old side by side

[Snailedlt]

Having few / fewer paths is, lot of the time a good idea, but wanting to optimize more than what you can get with svg optimizers (like SVG Viewer or SVGOMG) won't give you the expected result or will create unstable files

I don't have the knowledge to agree or disagree with you here, but your argument seems logical, so I'm just gonna wait and see what the other @devicons/maintainer s think about this one

[BenSouchet]

@Snailedlt Nice, yep it's seems they are identical

I compared file size of the one you just created and it's heavier (16%), so don't know also what is better but SVG I created for this project had rendering issue and like I said when icomoon convert the SVG the result is a glyph so I think the two version, mine and yours will give the exact same result.

So at the end, the SVG with only one path that is heavier and impossible to edit again (since every shape is merged) is maybe not the best one.

Yeah I'm also interested to see what the others maintainers think on that topic :)

[Snailedlt]

Yeah from what I can tell multiple paths is better in this instance, but I'm hesitant to merge because of the SVG Standards like I mentioned earlier.

I guess we'll have to wait and see for the other maintainers

[github-actions]

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

1. The number of Glyphs matches the number of SVGs that were selected.
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

[Snailedlt]

Since we haven't heard anything from the other maintainers I think we're safe to merge this.

@devicons/maintainer
I'll ping one last time, and if there are no comments by tomorrow (same time as now), I'll go ahead and merge.

[Panquesito7]

Looking great. Thanks! 🎉

__
 Summary: 👌 This code looks good  |  Tags: Efficient