-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: v8 (original, plain) #1354
Conversation
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
@ngdream could you try and fix the issues found by check-bot above? |
thanks |
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem.
Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
This comment was marked as outdated.
This comment was marked as outdated.
@ngdream the icon doesn't look right when uploaded as a font to icomoon. Are there any icons you could upload that are unicolored? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank
Co-authored-by: David Leal <halfpacho@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
let's merge now 😢 |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a small commit to get this through, hope that's okey with you @ngdream :)
LGTM ✔️
Thank you for your contributions! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a tiny change to align the devicon.json
. Hope that's ok @ngdream.
Approved! ✔
Thank you for contributing! 🚀
Fixing alignment of line 7979.
@Panquesito7 This is ready for merging now if you agree. Your review is currently blocking the merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
add icon for google v8 engine
This PR closes #1352