Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: livewire (original, original-wordmark, plain, plain-wordmark) #1415

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

Panquesito7
Copy link
Member

Double check these details before you open a PR

Special thanks to @Snailedlt for their tremendous help! 🚀

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #855

Link to prove your SVG is correct and up-to-date.

https://laravel-livewire.com/

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 2, 2022
@Snailedlt Snailedlt requested review from a team and amacado and removed request for a team October 2, 2022 20:04
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 2, 2022
@github-actions

This comment was marked as outdated.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️
Thank you for your continued contributions,! 💯
Looking forward to the next one 🚀

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woopsie

@Panquesito7 like we discussed on Discord, it seems like icomoon isn't rendering the icon fonts correctly with the masks. Notice in the images below how the screenshots from icomoon don't have the eye cutout, while the SVG versions uploaded here do.

Comparison

How they should look

image

How they look on icomoon

image

image

Summary

The plain icons need to be fixed (or removed) before merging to develop

@Panquesito7
Copy link
Member Author

What should we do about it, then? 🤔

@Snailedlt
Copy link
Collaborator

What should we do about it, then? 🤔

Either remove the plain icons or find another way to clip out the shapes.

I suggest trying to do it with inkscape like so: https://graphicdesign.stackexchange.com/a/42590

@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 5, 2022
@devicons devicons deleted a comment from github-actions bot Oct 5, 2022
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 5, 2022
@devicons devicons deleted a comment from github-actions bot Oct 5, 2022
Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Panquesito7
Copy link
Member Author

Nice! It finally looks good. 🙂

@Panquesito7 Panquesito7 linked an issue Oct 6, 2022 that may be closed by this pull request
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✔️
Kinda sad you force pushed so I can't see the diff easily, but as long as it works I guess it's okey :)

@Snailedlt Snailedlt merged commit f1f401a into develop Oct 7, 2022
@Panquesito7 Panquesito7 deleted the add_livewire branch October 11, 2022 04:18
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…k) (devicons#1415)

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…k) (devicons#1415)

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…k) (devicons#1415)

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Livewire
2 participants