Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: phoenix (original, original-wordmark, plain, plain-wordmark) #1535

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

lunatic-fox
Copy link
Contributor

@lunatic-fox lunatic-fox commented Nov 20, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

  • This PR fixes problems related to Phoenix icon
  • Updates original-wordmark and plain-wordmark versions
  • Removes plain version
  • Updates devicon.json entry

This PR closes #1519, #1528 and #1529

Notes

@lunatic-fox lunatic-fox changed the title update icon: phoenix () update icon: phoenix (original, original-wordmark, plain, plain-wordmark) Nov 20, 2022
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 20, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can ask some of the phoenix framework devs or their logo designer if they have a .svg version of the vertical wordmark version?

icons/phoenix/phoenix-original-wordmark.svg Outdated Show resolved Hide resolved
icons/phoenix/phoenix-plain-wordmark.svg Outdated Show resolved Hide resolved
@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Nov 22, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

@Snailedlt
Copy link
Collaborator

@cyberalien does this look good to you too?

@cyberalien
Copy link
Contributor

Looks good

@Snailedlt Snailedlt merged commit 07a3a20 into devicons:develop Nov 22, 2022
@lunatic-fox lunatic-fox deleted the fix_phoenix branch June 1, 2023 12:30
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants