Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: ngrx (original, plain) #1753

Merged
merged 7 commits into from
May 13, 2023

Conversation

sinuheshinbr
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1725

Link to prove your SVG is correct and up-to-date.

https://github.com/ngrx/platform/blob/0a13c4d89876f1ed399d2ec3cc46bda933a539b8/projects/ngrx.io/src/assets/images/badge.svg

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just a few small things to fix before it can be merged

devicon.json Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
icons/ngrx/ngrx-plain.svg Outdated Show resolved Hide resolved
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt
Copy link
Collaborator

@Panquesito7 Any idea why the checks are failing?

sinuheshinbr and others added 2 commits May 4, 2023 11:50
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@lunatic-fox lunatic-fox changed the title new icon: NgRx (original, plain) new icon: ngrx (original, plain) May 5, 2023
Add newline at the end of file.
@lunatic-fox
Copy link
Contributor

plain
plain

plain #412846
plain-colored

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✔
Thank you for this contribution! 🚀

@Panquesito7
Copy link
Member

@Panquesito7 Any idea why the checks are failing?

Not sure, seems to be a CodeQL workflow issue, which should be reported separately.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for contributing! 🚀
And thanks, @lunatic-fox, for the screenshots. 🙂

@Panquesito7 Panquesito7 merged commit 2532a68 into devicons:develop May 13, 2023
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label May 13, 2023
@sinuheshinbr sinuheshinbr deleted the feature/ngrx branch May 16, 2023 13:28
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants