Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: detaspace (original, original-wordmark, line, line-wordmark) #1860

Merged
merged 12 commits into from
Jul 1, 2024

Conversation

lemonyte
Copy link

@lemonyte lemonyte commented Aug 24, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

Link to prove your SVG is correct and up-to-date.

https://deta.space/
https://github.com/deta
https://deta.space/landing-page/assets/logo.20539aa2.svg
https://github.com/deta/space-docs/blob/main/.github/deta.svg

icons/detaspace/detaspace-original.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@Snailedlt
Copy link
Collaborator

@lemonyte Let us know if you need any help with this one :)

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 30, 2023
@lemonyte
Copy link
Author

The blocker here is that a plain version of the icon would look like a plain circle. I don't want to move forward with modifications to the icon without approval from @abdelhai , so for now let's just keep this a draft.

@Snailedlt
Copy link
Collaborator

Fair enough!
I do have an idea for how the icon could be modified, I can try to upload an example soon so you can see if you want :)

@lemonyte
Copy link
Author

I can try to upload an example soon so you can see if you want

Sure! I should have been more clear: I'm open to discuss modifications, but would like to hold off on merging any modified icons without approval 😄

@canaleal
Copy link
Member

canaleal commented Nov 1, 2023

Small suggestion, but for the plain SVG it could be a could be a circle with white spacing in between each path. Not exactly a perfect solution, but I don't see another clear way to not make it look like a big 1 color circle.

image

If a plain SVG cannot be made, a line SVG can be used for the font version. Similar to how the Sketch Icon only has an original and line version.

image

@Snailedlt
Copy link
Collaborator

The line version looks good!

@lemonyte lemonyte marked this pull request as ready for review November 18, 2023 00:39
@lemonyte
Copy link
Author

Hi @Snailedlt, what are your thoughts on merging this? I believe all the issues have been resolved here.

@lemonyte lemonyte changed the title new icon: detaspace (original, original-wordmark) new icon: detaspace (original, original-wordmark, line, line-wordmark) May 20, 2024
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@lemonyte
Copy link
Author

It seems that the threedsmax and reactrouter icons in devicon.json are causing the check to fail. The detaspace icon is in the correct alphabetical position.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to do before this can be merged.
PS: Don't worry about the sorting of devicon.json. We'll fix that in a separate PR

devicon.json Outdated Show resolved Hide resolved
icons/detaspace/detaspace-line.svg Outdated Show resolved Hide resolved
icons/detaspace/detaspace-line-wordmark.svg Outdated Show resolved Hide resolved
lemonyte and others added 2 commits May 21, 2024 19:04
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@lemonyte lemonyte requested a review from Snailedlt May 21, 2024 23:19
@lemonyte
Copy link
Author

@Snailedlt is this good to merge? Please let me know if there is anything else to address in this PR :)

@Snailedlt Snailedlt requested review from a team and ConX and removed request for a team June 21, 2024 23:19
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No artifacts in the line icons:

image

@canaleal canaleal dismissed Snailedlt’s stale review July 1, 2024 03:05

Issue has been resolved with the latest changes.

@canaleal canaleal merged commit 5cf3ceb into devicons:develop Jul 1, 2024
5 checks passed
@lemonyte lemonyte deleted the detaspace branch July 1, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants