Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Icon: Forgejo (Original) #1926

Closed
wants to merge 13 commits into from
Closed

New Icon: Forgejo (Original) #1926

wants to merge 13 commits into from

Conversation

Yashh56
Copy link
Contributor

@Yashh56 Yashh56 commented Oct 23, 2023

(Hacktobeberfest PR)

PR name matches the format new icon: Icon name (versions separated by a comma). More details here

PR's base is the develop branch.

Your icons are inside a folder as seen here

SVG matches the standards laid out here

A new object is added in the devicon.json file as seen here

This PR closes #1902

Link to prove your SVG is correct and up-to-date.
https://codeberg.org/forgejo/governance/media/branch/main/branding/logo/forgejo.svg

@Yashh56
Added
bfec6ce 
Forgejo
Icon
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 23, 2023

Hey, Maintainer Please Review This PR !!

weh
weh requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched a bit, and only found the wordmark version of the Logo https://codeberg.org/forgejo/pages/src/branch/main/images/forgejo-wordmark.svg

Can you add the wordmark version too?
Also i think we need the plain version to be used for the font.
So in the end original, original-wordmark, plain, plain-wordmark

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 23, 2023

how should I convert the original to plain? @weh

@weh
Copy link
Contributor

weh commented Oct 23, 2023

I prefer to use Inkscape for this.
The goal is to "union all paths". you may need to convert some parts using "Object to Path" or "Stroke to Path" and finally mark all elements and use "path/Union"

Followed by

  • Resize Page to Content (to remove padding)
  • Change the Page format back to square
  • Center the Logo
  • Resize the image using Iloveimg
  • Optimize using Vecta.io
  • re-add the viewBox

That is my preferred workflow. You can find the Links here: https://github.com/devicons/devicon/wiki/Recommended-resources-and-tools

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 23, 2023

After merging the path it looks like this

_forgejo-original-wordmark svg - Inkscape 10_23_2023 10_43_22 PM

@Yashh56
Added
6ec6c9f 
original
wordmark
@canaleal
Copy link
Contributor

canaleal commented Oct 24, 2023 •
edited
Loading

Hey @Yashh56 , sorry for the super long comment, but here's the workflow I follow to create new Icons.

Resize the SVG and Align Horizontally/ Vertically (Inkscape)

  1. Inside Inkscape, select the File option from the toolbar and in the dropdown select Document properties.

image

  1. Inside document properties change the width to 128.
  2. Change the height to 128.

image

  1. To resize the SVG while maintaining the Aspect Ratio, press ctrl-a to select all paths.
  2. Right click on the SVG and then select group from the dropdown.

image

  1. Click the lock icon in the toolbar.
  2. Then select the largest of these 2 numbers (width or height) and change the value to 128. This will resize the icon to fit the viewbox. In the example below, the width was changed to 128.

image

  1. To align the SVG, open the align menu.
  2. Then click the center horizontally button.
  3. Then click the align vertically button.

image

  1. Right click on the SVG (Make sure all paths are selected using ctrl-a) and then select ungroup from the dropdown.

image

  1. You can now save the SVG.
  2. Make sure to optimize the SVG prior to making a new PR. You can follow the steps below to optimize the SVG.

Unify the Paths and create Plain Icons (Inkscape)

Shout out to @yeyeto2788 and @lunatic-fox for these steps.

  1. Load the Icon inside inkscape and press ctrl-a to select all paths.
  2. Right click on the SVG and select ungroup in the menu to ungroup all paths.

image

  1. Next, click the Path option in the toolbar and in the the dropdown select union to combine all paths into 1 path.

image

  1. Open the SVG inside your text editor (I use VS Code) and check that only 1 path exists.
  2. Next, update the SVG fill to be in hexadecimal format and only use 1 color (The main/ most prominent color from original SVG, black, or white).

image

  1. You can now save the SVG.
  2. Make sure to resize and optimize the SVG prior to making a new PR. You can follow the steps below to optimize the SVG.

Why Optimize the SVG (Inkscape)

  1. After making the changes and saving the SVG, Inkscape will add a lot of new attributes inside the SVG. These attributes are used when you need to edit the SVGs inside inkscape, but are not required in Devicon and they should be removed.

image

  1. To remove the attributes from the SVG, use tools like SVGOMG or SVGViewer to optimize the SVG Code. I prefer using SVGOMG as you only need to select a few options to optimize the SVG.

Optimizing the SVG using SVGOMG

Shout out to @BenSouchet, all the steps I used were from this comment

  1. Copy the full SVG code of the SVG you want to optimize.

image

  1. Go to SVGOMG, and on the left side click on Paste markup.

image

  1. Paste the SVG code into the input box.

image

  1. Now that the SVG has been loaded in the interface, let's start optimizing the SVG using the Features menu.

image

  1. Disable Compare gzipped, enable Multipass, and do not touch the precision slidebar.

image

  1. Enable ALL the features EXCEPT:
  • Remove xmlns
  • Round/rewrite number lists
  • Replace duplicate elements with links

image
image
image

  1. Click the copy button to copy the SVG code.

image

  1. Paste the SVG code inside your SVG file.
  2. Add an empty newline at the end of file to ensure compatibility with older Devicon versions.

image

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 24, 2023

Hey @canaleal Are these changes correct?

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 24, 2023

After merging the path I am facing the same issue

_forgejo-original-wordmark svg - Inkscape 10_23_2023 10_43_22 PM

@canaleal
Copy link
Contributor

Hey @Yashh56, I took a look at the Icon and I see what the problem is.
The symbol on the left is a stroke, not an object. So when you try to unify all paths together, it gets messed up.

The strokes can be converted into paths by selecting all elements on the page ctrl-a and then doing ctrl + alt + a or selecting stroke-to-path in the path dropdown.

image

You can still follow the workflow I posted above to optimize, resize, and make plain SVGs.

Original SVG Wordmark

Here, I cleaned up the original SVG and converted it to object paths. This can be used to create the plain icons.

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 800 300"><path fill="#f50" d="M91.65 20.65c-39.052 0-71 31.948-71 71v115h27v-115c0-24.46 19.54-44 44-44h23v-27z"/><path fill="#c00" d="M91.65 95.4c-39.052 0-71 31.948-71 71v40.25h27V166.4c0-24.46 19.54-44 44-44h23v-27Z"/><path fill="#f50" d="M126.15 7.15c-14.817 0-27 12.183-27 27s12.183 27 27 27 27-12.183 27-27-12.183-27-27-27zm0 16c6.17 0 11 4.83 11 11s-4.83 11-11 11-11-4.83-11-11 4.83-11 11-11z"/><path fill="#c00" d="M126.15 81.9c-14.817 0-27 12.183-27 27s12.183 27 27 27 27-12.183 27-27-12.183-27-27-27zm0 16c6.17 0 11 4.83 11 11s-4.83 11-11 11-11-4.83-11-11 4.83-11 11-11zm-92 93.25c-14.817 0-27 12.183-27 27s12.183 27 27 27 27-12.183 27-27-12.183-27-27-27zm0 16c6.17 0 11 4.83 11 11s-4.83 11-11 11-11-4.83-11-11 4.83-11 11-11z"/><path fill="#f50" d="M202.327 241.983q-17.68 0-31.734-7.706-13.826-7.934-21.986-21.76-7.934-13.827-7.934-31.507 0-17.907 7.934-31.507 8.16-13.826 21.986-21.533 13.827-7.933 31.734-7.933 17.68 0 31.506 7.933 14.054 7.707 21.987 21.533 7.933 13.6 7.933 31.507 0 17.68-7.933 31.507-7.933 13.826-21.987 21.76-13.826 7.706-31.506 7.706zm0-16.546q12.24 0 21.76-5.44 9.52-5.667 14.96-15.64 5.666-10.2 5.666-23.347 0-13.373-5.666-23.347-5.44-9.973-14.96-15.413-9.52-5.44-21.76-5.44-12.24 0-21.76 5.44-9.52 5.44-15.187 15.413-5.44 9.974-5.44 23.347 0 13.147 5.44 23.347 5.667 9.973 15.187 15.64 9.52 5.44 21.76 5.44zm77.523 15.413V121.17h18.134v32.64l-1.813-7.027q4.986-12.92 16.773-19.72 11.786-7.027 29.24-7.027v18.587q-1.133-.226-2.267-.226-1.133-.227-2.266-.227-17.907 0-28.334 11.107-10.426 10.88-10.426 31.28v60.293zm125.297 45.107c-10.88 0-21.457-1.587-31.733-4.76-10.124-3.022-18.435-7.405-24.933-13.147l9.52-14.733c5.59 4.986 12.466 8.915 20.626 11.786 8.311 2.871 16.925 4.307 25.84 4.307 14.658 0 25.463-3.475 32.414-10.427 6.951-6.8 9.393-17.34 10.426-31.506l2-27.427 2.267-22.213-1.587-22.214 8.72-9.746c11.18 15.476 7.414 50.817 7.414 79.56 0 20.853-5.138 36.115-15.413 45.786-10.276 9.823-25.463 14.734-45.56 14.734zm1.28-49.867c-11.484 0-21.835-2.418-31.053-7.253-9.067-4.987-16.244-11.863-21.533-20.627-5.29-8.764-7.934-18.889-7.934-30.373 0-11.485 2.645-21.534 7.934-30.147 5.289-8.765 12.466-15.565 21.533-20.4 9.218-4.836 19.569-7.254 31.053-7.254 10.427 0 23.796 2.192 32.107 6.574 8.462 4.231 15.187 10.653 20.174 19.266 5.137 8.614 5.706 19.267 5.706 31.96 0 12.845-4.569 23.574-9.706 32.187-4.987 8.614-11.712 15.111-20.174 19.494-8.311 4.382-17.68 6.573-28.106 6.573zm-.186-16.773c8.462 0 15.942-1.738 22.44-5.214 6.498-3.475 11.56-8.31 15.187-14.506 3.777-6.347 5.666-13.6 5.666-21.76 0-8.16-1.889-15.338-5.666-21.534-3.627-6.195-8.69-10.955-15.187-14.28-6.498-3.475-13.978-5.213-22.44-5.213-8.311 0-15.716 1.738-22.214 5.213-6.497 3.325-11.635 8.085-15.413 14.28-3.627 6.196-5.44 13.374-5.44 21.534 0 8.16 1.813 15.413 5.44 21.76 3.778 6.195 8.916 11.03 15.413 14.506 6.497 3.476 13.903 5.214 22.214 5.214zm195.621 66.64c-4.987 0-9.747-.605-14.28-1.814-4.533-1.208-8.311-3.097-11.333-5.666l6.346-14.28c4.685 3.778 10.73 5.666 18.134 5.666 6.044 0 10.653-1.813 13.826-5.44 3.325-3.626 4.987-9.066 4.987-16.32V141.17h19.04v106.933c0 11.636-3.173 20.854-9.52 27.654-6.346 6.8-15.413 10.2-27.2 10.2zm115.47-43.974q-17.68 0-31.733-7.706-13.826-7.934-21.986-21.76-7.934-13.827-7.934-31.507 0-17.907 7.934-31.507 8.16-13.826 21.986-21.533 13.827-7.933 31.734-7.933 17.68 0 31.506 7.933 14.054 7.707 21.987 21.533 7.933 13.6 7.933 31.507 0 17.68-7.933 31.507-7.933 13.826-21.987 21.76-13.826 7.706-31.506 7.706zm0-16.546q12.24 0 21.76-5.44 9.52-5.667 14.96-15.64 5.667-10.2 5.667-23.347 0-13.373-5.666-23.347-5.44-9.973-14.96-15.413-9.52-5.44-21.76-5.44-12.24 0-21.76 5.44-9.52 5.44-15.187 15.413-5.44 9.974-5.44 23.347 0 13.147 5.44 23.347 5.667 9.973 15.187 15.64 9.52 5.44 21.76 5.44zm-170.194 16.81q-18.813 0-33.32-7.707-14.28-7.933-22.44-21.76-7.933-13.827-7.933-31.507t7.707-31.506q7.706-13.827 21.08-21.534 13.6-7.933 30.826-7.933 16.32 0 29.24 7.253 12.92 7.254 20.627 20.4 7.934 12.92 8.387 30.374l-101.774 19.946-.906-13.826 91.573-17.68-7.026 9.973q0-11.333-5.214-20.4-4.986-9.067-14.053-14.28-9.067-5.44-20.854-5.44-12.013 0-21.533 5.44-9.293 5.44-14.507 15.187-5.213 9.746-5.213 22.893 0 13.827 5.667 24.253 5.893 10.2 16.093 15.867 10.427 5.44 24.027 5.44 10.88 0 19.947-3.627 9.066-3.853 15.64-11.56l10.426 12.24q-7.707 9.52-19.72 14.507-12.013 4.987-26.747 4.987zM628 84.75c-13.256 0-24.15 10.894-24.15 24.15 0 13.256 10.894 24.15 24.15 24.15s24.15-10.894 24.15-24.15c0-13.256-10.894-24.15-24.15-24.15Zm0 13.8c5.798 0 10.35 4.553 10.35 10.35 0 5.798-4.552 10.35-10.35 10.35s-10.35-4.552-10.35-10.35c0-5.797 4.552-10.35 10.35-10.35z"/></svg>

@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 24, 2023

I will make this changes ASAP @canaleal Thanks for the help

@Yashh56
Added
c4494c0 
Plain svg
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 24, 2023

Hey @canaleal Are these changes correct?

weh
weh requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some things to fix here

icons/forgejo/forgejo-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/forgejo/forgejo-plain-wordmark.svg Outdated
@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path d="M19.74 0c-1.644 0-3.092 2.504-3.87 6.198h-1.853C7.54 6.198 2.24 20.865 2.24 38.794v47.373C.906 88.324 0 92.322 0 96.87c0 6.802 2.021 12.396 4.479 12.396s4.479-5.594 4.479-12.396c0-4.548-.906-8.546-2.24-10.703V73.112c0-11.23 3.242-20.2 7.3-20.2h1.855c.78 3.69 2.224 6.197 3.868 6.197 2.458 0 4.479-5.593 4.479-12.396 0-6.802-2.021-12.395-4.48-12.395-1.643 0-3.087 2.507-3.867 6.198h-1.856c-2.751 0-5.288 2.653-7.299 7.07v-8.792c0-11.23 3.242-20.2 7.3-20.2h1.851c.78 3.693 2.227 6.197 3.872 6.197 2.458 0 4.479-5.593 4.479-12.395C24.22 5.593 22.199 0 19.74 0Zm0 7.346c1.024 0 1.825 2.217 1.825 5.05 0 2.832-.8 5.05-1.824 5.05s-1.825-2.218-1.825-5.05c0-2.833.801-5.05 1.825-5.05zm83.25 28.28c-2.198 0-4.005 5.002-4.005 11.087 0 6.086 1.807 11.088 4.006 11.088 2.199 0 4.006-5.002 4.006-11.088 0-6.085-1.807-11.087-4.006-11.087zm-83.25 6.037c1.024 0 1.825 2.218 1.825 5.05 0 2.833-.8 5.05-1.824 5.05s-1.825-2.217-1.825-5.05c0-2.832.801-5.05 1.825-5.05zm83.25.299c.963 0 1.718 2.09 1.718 4.751 0 2.662-.755 4.752-1.717 4.752-.962 0-1.717-2.09-1.717-4.752 0-2.661.755-4.751 1.717-4.751zm-47.412 9.863c-1.93 0-3.547 1.076-4.85 3.227-1.102 1.758-1.918 4.225-2.482 7.32V52.346h-3.009v54.945h3.159v-27.68c0-6.244.576-11.03 1.73-14.36 1.153-3.4 2.72-5.1 4.7-5.1a.77.77 0 0 1 .376.104c.125 0 .25.035.376.104zm10.657 0c-1.905 0-3.622 1.11-5.152 3.33-1.504 2.22-2.694 5.342-3.571 9.366-.878 3.955-1.317 8.569-1.317 13.842 0 5.272.44 9.92 1.317 13.944.877 4.023 2.067 7.18 3.571 9.47 1.53 2.22 3.247 3.329 5.152 3.329 1.73 0 3.284-1.006 4.662-3.017.85-1.219 1.582-2.838 2.22-4.768l-.1 3.83c-.172 6.504-.577 11.343-1.73 14.465-1.153 3.192-2.946 4.787-5.377 4.787-1.48 0-2.908-.659-4.287-1.977-1.353-1.318-2.494-3.122-3.421-5.411l-1.58 6.764c1.078 2.636 2.457 4.648 4.136 6.036 1.705 1.456 3.46 2.185 5.264 2.185 3.335 0 5.854-2.255 7.558-6.765 1.705-4.44 2.557-11.446 2.557-21.02 0-13.195.625-29.42-1.23-36.526-.827-3.954-1.942-6.903-3.346-8.845-1.379-2.012-3.596-3.019-5.326-3.019zm-33.858.001c-1.98 0-3.735 1.215-5.264 3.643-1.529 2.358-2.745 5.654-3.647 9.885-.878 4.163-1.316 8.984-1.316 14.465 0 5.411.438 10.233 1.316 14.465.902 4.232 2.118 7.562 3.647 9.99 1.554 2.358 3.309 3.537 5.264 3.537s3.698-1.179 5.227-3.537c1.554-2.428 2.77-5.758 3.647-9.99.877-4.232 1.316-9.054 1.316-14.465 0-5.48-.439-10.302-1.316-14.465-.877-4.231-2.093-7.527-3.647-9.885-1.53-2.428-3.272-3.643-5.227-3.643zm85.433 0c-1.98 0-3.735 1.215-5.264 3.643-1.53 2.358-2.745 5.654-3.647 9.885-.878 4.163-1.316 8.984-1.316 14.465 0 5.411.438 10.233 1.316 14.465.902 4.232 2.118 7.562 3.647 9.99 1.554 2.358 3.309 3.537 5.264 3.537s3.698-1.179 5.227-3.537c1.554-2.428 2.77-5.758 3.647-9.99.877-4.232 1.316-9.054 1.316-14.465 0-5.48-.439-10.302-1.316-14.465-.877-4.231-2.093-7.527-3.647-9.885-1.53-2.428-3.272-3.643-5.227-3.643zm-28.91.121c-1.905 0-3.61 1.214-5.113 3.642-1.48 2.359-2.645 5.655-3.497 9.887-.853 4.231-1.279 9.053-1.279 14.464s.439 10.232 1.316 14.464c.903 4.232 2.143 7.562 3.723 9.99 1.604 2.359 3.447 3.538 5.527 3.538 1.63 0 3.108-.763 4.437-2.289 1.328-1.526 2.419-3.746 3.271-6.66l-1.73-5.619c-.726 2.359-1.591 4.127-2.594 5.307-1.003 1.11-2.106 1.665-3.309 1.665-1.504 0-2.832-.833-3.986-2.498-1.128-1.734-2.017-4.162-2.669-7.284a45.141 45.141 0 0 1-.495-3.255l16.062-8.712c-.05-5.342-.514-9.99-1.391-13.945-.853-4.023-1.993-7.145-3.422-9.365-1.429-2.22-3.046-3.33-4.85-3.33Zm0 7.492c1.304 0 2.457.833 3.46 2.498 1.002 1.596 1.78 3.78 2.33 6.556.353 1.694.584 3.534.721 5.487L82.09 81.098c-.012-.558-.032-1.101-.032-1.678 0-4.024.288-7.528.864-10.511.577-2.983 1.38-5.307 2.407-6.972 1.053-1.665 2.244-2.498 3.572-2.498zm-56.523.088c1.354 0 2.557.832 3.61 2.497s1.88 4.023 2.482 7.076c.626 3.053.94 6.626.94 10.719 0 4.024-.314 7.597-.94 10.719-.602 3.052-1.43 5.445-2.482 7.18-1.053 1.664-2.256 2.498-3.61 2.498s-2.557-.834-3.61-2.499c-1.052-1.734-1.892-4.127-2.519-7.18-.601-3.121-.902-6.694-.902-10.718 0-4.093.3-7.666.902-10.72.627-3.052 1.467-5.41 2.52-7.075 1.052-1.665 2.255-2.497 3.61-2.497zm33.827 0c1.404 0 2.645.798 3.723 2.393 1.077 1.527 1.917 3.712 2.519 6.556.626 2.844.94 6.14.94 9.887 0 3.746-.314 7.076-.94 9.99-.602 2.844-1.441 5.064-2.52 6.66-1.077 1.595-2.318 2.392-3.722 2.392-1.379 0-2.607-.797-3.685-2.393-1.078-1.596-1.93-3.815-2.557-6.66-.602-2.913-.902-6.243-.902-9.99 0-3.746.3-7.042.902-9.886.627-2.844 1.48-5.03 2.557-6.556 1.078-1.595 2.306-2.393 3.685-2.393zm51.606 0c1.354 0 2.557.832 3.61 2.497s1.88 4.023 2.481 7.076c.627 3.053.94 6.626.94 10.719 0 4.024-.313 7.597-.94 10.719-.601 3.052-1.429 5.445-2.481 7.18-1.053 1.664-2.256 2.498-3.61 2.498s-2.557-.834-3.61-2.499c-1.053-1.734-1.892-4.127-2.519-7.18-.601-3.121-.902-6.694-.902-10.718 0-4.093.3-7.666.902-10.72.627-3.052 1.466-5.41 2.52-7.075 1.052-1.665 2.255-2.497 3.609-2.497zm-16.222 2.001v49.093c0 3.33-.276 5.828-.827 7.493-.527 1.665-1.291 2.497-2.294 2.497-1.228 0-2.23-.866-3.008-2.6l-1.053 6.555c.501 1.18 1.128 2.046 1.88 2.601.752.555 1.542.833 2.369.833 1.955 0 3.46-1.56 4.512-4.682 1.053-3.122 1.58-7.354 1.58-12.697V61.528ZM4.479 91.82c1.023 0 1.825 2.217 1.825 5.05 0 2.833-.802 5.05-1.825 5.05-1.024 0-1.825-2.217-1.825-5.05 0-2.833.801-5.05 1.825-5.05z"/></svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Image also looks squished, the aspect ratio seems to be wrong here
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed all the instructions @weh

icons/forgejo/forgejo-plain.svg Outdated
@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><g fill="#f9f9f9" stroke="#000"><path stroke-width="15.166" d="M37.261 105.534v-59.45c0-16.754 13.581-30.33 30.33-30.33h12.133"/><path stroke-width="15.166" d="M37.261 105.534V87.332c0-16.75 13.581-30.33 30.33-30.33h12.133"/><path stroke-width="9.099" d="M99.136 15.754c0 6.028-4.886 10.918-10.918 10.918-6.029 0-10.918-4.89-10.918-10.918 0-6.033 4.89-10.922 10.918-10.922 6.032 0 10.918 4.89 10.918 10.922zm0 41.248c0 6.033-4.886 10.918-10.918 10.918-6.029 0-10.918-4.885-10.918-10.918 0-6.028 4.89-10.918 10.918-10.918 6.032 0 10.918 4.89 10.918 10.918zM48.18 112.81c0 6.033-4.89 10.922-10.919 10.922-6.032 0-10.918-4.89-10.918-10.922 0-6.028 4.886-10.918 10.918-10.918 6.029 0 10.918 4.89 10.918 10.918zm0 0"/></g></svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are two white line left from editing.
image

icons/forgejo/forgejo-plain.svg Outdated Show resolved Hide resolved
Yashh56 and others added 3 commits October 24, 2023 15:09
@Yashh56 @weh
Update icons/forgejo/forgejo-plain.svg
ad85313 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
@Yashh56 @weh
Update icons/forgejo/forgejo-plain-wordmark.svg
fb8ce0a 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
@Yashh56
Update forgejo-plain.svg
06e49a6
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 24, 2023

Hey, Maintainer Please Review This PR !!

weh
weh requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let me help you a bit with the images here.

Next time try to fix what the reviewers tell you. Don't worry if you need a bit of time and maybe also need to learn Inkscape. Don't rush and ask for multiple reviews, if you can see with your own eyes, that the images look wrong.

I guess i should also take some time and try to add some more hints, on how to fix specific things, when editing SVG images.

Thank you for your contribution, and happy hacktoberfest :)

icons/forgejo/forgejo-original.svg Outdated Show resolved Hide resolved
icons/forgejo/forgejo-plain.svg Outdated Show resolved Hide resolved
icons/forgejo/forgejo-original-wordmark.svg Outdated Show resolved Hide resolved
icons/forgejo/forgejo-plain-wordmark.svg Outdated Show resolved Hide resolved
@weh weh added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 24, 2023
Yashh56 and others added 4 commits October 24, 2023 22:01
@Yashh56 @weh
Update icons/forgejo/forgejo-original.svg
4bcd480 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
@Yashh56 @weh
Update icons/forgejo/forgejo-plain.svg
e4eeab7 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
@Yashh56 @weh
Update icons/forgejo/forgejo-original-wordmark.svg
f160842 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
@Yashh56 @weh
Update icons/forgejo/forgejo-plain-wordmark.svg
03bf8c1 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
@Yashh56
Copy link
Contributor Author

Yashh56 commented Oct 24, 2023

thank you for the help @weh

@Snailedlt
Copy link
Collaborator

Wow great tutorial here @canaleal!
#1926 (comment)

Would you mind adding the thing with objects, and adding it to this issue?
#1306

Snailedlt
Snailedlt requested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!
Just some small suggestions for devicon.json

devicon.json
"plain-wordmark"
],
"font": [
"original"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little whoopsie that needs to be fixed ;)

Suggested change
"original"
"plain",
"plain-wordmark"

devicon.json
"name": "forgejo",
"altnames": [],
"tags": [
"software"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"software"
"software",
"git",
"version-control"

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 30, 2023
lunatic-fox
lunatic-fox requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we have to do some little adjustments here. 🔧

  • All icons need to have one line with the SVG code and another with the newline character, but the files have 3 lines instead. If you're using some code editor, please take a look if you have just 2 lines or if when you trying to remove the third line it inserts a newline automatically - if that is the case, remove any newlines until the SVG code and wait for the code editor autocomplete it.
  • #000000 is the only fill color that can be omitted in most cases.

icons/forgejo/forgejo-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/forgejo/forgejo-plain.svg Outdated Show resolved Hide resolved
Yashh56 and others added 2 commits November 3, 2023 14:24
@Yashh56 @lunatic-fox
Update icons/forgejo/forgejo-plain-wordmark.svg
b69b931 
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
@Yashh56 @lunatic-fox
Update icons/forgejo/forgejo-plain.svg
b7dc6bc 
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
@Yashh56 Yashh56 closed this Feb 6, 2024
@Yashh56 Yashh56 deleted the feat/forgejo-icon branch February 6, 2024 03:39
@weh weh mentioned this pull request Feb 15, 2024
Open
6 tasks
This was referenced Feb 28, 2024
Merged
Open
@AnshSinghSonkhia
Copy link

AnshSinghSonkhia commented Feb 29, 2024 •
edited
Loading

Optimizing the SVG using SVGOMG

Optimizing is a 1 Click task with SVGVIEWER

I found it more easier to do with it.

  1. Visit https://www.svgviewer.dev
  2. Upload SVG or paste code

beforeSVG

  1. Click on Prettify Button.
  2. Click on Optimize Button.

BOOM !!! The SVG is optimized, without ruining the viewbox.

optimizedSVG

@AnshSinghSonkhia AnshSinghSonkhia mentioned this pull request Mar 23, 2024
Open
This was referenced Apr 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt requested changes

@lunatic-fox lunatic-fox lunatic-fox requested changes

@weh weh weh approved these changes

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Yashh56 @weh @canaleal @Snailedlt @AnshSinghSonkhia @lunatic-fox