Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) #1468

Merged
merged 10 commits into from
Nov 9, 2022

Conversation

yeyeto2788
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

**This PR closes #789 **

Link to prove your SVG is correct and up-to-date.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those don't look like the official logos 🙊
Please change to the official ones (I linked to them in issue #789)

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 19, 2022
@yeyeto2788
Copy link
Contributor Author

That is really weird cuz I do see it correctly in Inkscape
image

Any suggestions on how to fix it? Maybe exporting it differently?

@yeyeto2788
Copy link
Contributor Author

I'll grouping them to see if that fixes the issue.

@yeyeto2788
Copy link
Contributor Author

I had to use the ones you provided on the issue itself as the grouping didn't work. Thanks for that!

@lunatic-fox
Copy link
Contributor

Hello there!
@yeyeto2788 you're doing great!
I just have some recommendations to the icons.
First, I think you'll need to change the icons name and add two more icons:

  • original to original-wordmark
  • plain to plain-wordmark

And add the original and plain icons based on the square-like icon recommended by @Snailedlt on #789 issue.

To original-wordmark icon you can ungroup all and unify just "Jira Align" characters in one path.
To plain-wordmark icon, you can ungroup all and unify all in just one path.
All icons need to be an 128×128px square.

Wish for the best!

@yeyeto2788
Copy link
Contributor Author

Hey @lunatic-fox!

I think I have covered everything you asked me for but if you see there is something missing just let me know.

Best.

@lunatic-fox
Copy link
Contributor

The icons look great now @yeyeto2788! 🤩

However there are some issues yet:

  • plain and plain-wordmark paths need to be united in just one path, to keep them as simple as possible.
    Source doc: https://github.com/devicons/devicon/wiki/SVG-Standards

  • In devicon.json the icon color is #F04E98, I suggest #2684FF since is the main color of the original version.

  • You can add plain-wordmark to font array of versions object of devicon.json.

  • A recommendation is to ungroup all since you already fixed the invisible paths issue in your last icons.

Keep rocking! 🚀

@lunatic-fox lunatic-fox mentioned this pull request Oct 24, 2022
6 tasks
@yeyeto2788
Copy link
Contributor Author

Hey @lunatic-fox!

I hope this time is correct. So for uniting the path I followed these steps:

  1. Ungroup the objects Ctrl Shift G
  2. Select all Ctrl A
  3. Path > Union Ctrl + +

I guess that could be added into the documentation. I really helped me a lot the example with the box creation and this might as well help others.

@lunatic-fox
Copy link
Contributor

lunatic-fox commented Oct 25, 2022

Hello @yeyeto2788!
In short:

  • original
  • original-wordmark
  • plain

But plain-wordmark is grouped. The key command to ungroup is Shift+Ctrl+G, otherwise it'll probably group instead. However, you can also follow that way bellow.

Checking layers

  • Go to Layers and Objects. If it's not opened you can open it by Object > Layers and Objects... or Shift+Ctrl+L
  • If you see some layer with folder-icon, that means this layer is a group of layers.
  • You can ungroup this layer by right clicking on the layer folder-icon and selecting Ungroup.
  • To be sure that everything is ungrouped, all layers should be with this icon path-icon
  • Once all layers are paths path-icon, them select all and Unify by Path > Union or Ctrl++
  • Lastly you should see just one path-icon path layer.

Hope everything works fine! 👍🏼

@yeyeto2788
Copy link
Contributor Author

Hopefully this one is the last one. Once again sorry for the inconveniences.

Best.

@lunatic-fox
Copy link
Contributor

lunatic-fox commented Oct 26, 2022

No worries! There is no inconvenience at all. 🙂
Like the other PR, I haven't seen before just two things: the altnames and tags properties are missing after name property.

Suggestions of tags

"tags": [
    "development",
    "integration",
    "software"
]

The icons are great now! 🎉

Like I said before you can also contact us on Discord server.

I also loved your idea of adding some instructions on using Inkscape!
I think this should be a feature request to the Wiki.

@Snailedlt Snailedlt changed the title new icon: Jira Align (original,plain) new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) Oct 29, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 🚀

Just need to add the name with whitespaces as an altname and minimize all of the icons. You can minimize the icons like I explained here: https://github.com/devicons/devicon/pull/1465/files#r1008766362

devicon.json Outdated Show resolved Hide resolved
@Snailedlt
Copy link
Collaborator

@yeyeto2788

Hey @lunatic-fox!

I hope this time is correct. So for uniting the path I followed these steps:

  1. Ungroup the objects Ctrl Shift G
  2. Select all Ctrl A
  3. Path > Union Ctrl + +

I guess that could be added into the documentation. I really helped me a lot the example with the box creation and this might as well help others.

Yes, this could be added to the wiki as a part of this issue: #1306

@lunatic-fox
Copy link
Contributor

@yeyeto2788

Hey @lunatic-fox!
I hope this time is correct. So for uniting the path I followed these steps:

  1. Ungroup the objects Ctrl Shift G
  2. Select all Ctrl A
  3. Path > Union Ctrl + +

I guess that could be added into the documentation. I really helped me a lot the example with the box creation and this might as well help others.

Yes, this could be added to the wiki as a part of this issue: #1306

I'll be adding this later Instructions to resize to square and Checking layers.

@Snailedlt
Copy link
Collaborator

@lunatic-fox Nice! Please add links to those as comments with the same format I used in the issue I created: #1306

yeyeto2788 and others added 2 commits October 31, 2022 07:25
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 31, 2022
@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'jiraalign-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt
Copy link
Collaborator

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'jiraalign-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot 😄

@yeyeto2788 Please resize the viewbox as explained above. I recommend using iloveimg to make it fast and easy :)

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 31, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@github-actions
Copy link
Contributor

env.MESSAGE

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, but the icons are still quite big. Could you please optimize them using this method? #1306 (comment)

@yeyeto2788
Copy link
Contributor Author

Looks good now, but the icons are still quite big. Could you please optimize them using this method? #1306 (comment)

I did that step before my last commit but I have done again hoping it does not screw anything as the last time.

Best.

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! ✔️
Thank you for your contribution! 💯

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✔
Great contribution! 🚀

@Snailedlt Snailedlt merged commit 73ddc75 into devicons:develop Nov 9, 2022
@yeyeto2788 yeyeto2788 deleted the jiraalign branch March 7, 2023 09:03
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants