Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a color picker in the header #704

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Add a color picker in the header #704

merged 2 commits into from
Jun 30, 2021

Conversation

Thomas-Boi
Copy link
Member

Feature:

  • This add a color picker functionality to the background of the font and SVGs in the header (the aside technically).
    image

Notes:

  • Each font and SVG section has its own color. When the user select a new icon, the color will reset to the default color, which is our page color.
  • I thought of using a checkerboard pattern but decided against it. It doesn't look good for some icons:
    image

This will closes #698.

@amacado amacado self-requested a review June 30, 2021 09:45
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI could be prettier I guess, but it will do it's job ;-) Thank you @Thomas-Boi

@amacado amacado merged commit d1f8d17 into develop Jun 30, 2021
@amacado amacado deleted the thomas/colorPicker branch June 30, 2021 09:47
@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented Jun 30, 2021

@amacado I can change the color picker UI, just give me some suggestions :)

There are a few libraries out there or we can style it differently. Maybe a button with an icon that will change color depending on the color input?

image

EDIT: Let's put all all UI suggestion in #698 so it's easier to keep track of on the website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Background in the website should be able to change its color
2 participants