New Feature: Fixed capture.canvas issue as seen in #822
#829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas-Boi
force-pushed
the
thomas/bugFix/peekScriptBugFix
branch
from
19a7120
to
3b5aa34
Compare
|
@Panquesito7 after we merged this fix, we can re-run it on your Just fyi: I tested the script and it ran properly. It spotted that your |
2 tasks
Thomas-Boi
force-pushed
the
thomas/bugFix/peekScriptBugFix
branch
from
3b5aa34
to
65cc891
Compare
Thomas-Boi
force-pushed
the
thomas/bugFix/peekScriptBugFix
branch
from
65cc891
to
c1bd4a6
Compare
|
The force push is because I forgot to clean up after I finished testing my code |
amacado
approved these changes
Sep 2, 2021
This was referenced Sep 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature section
Double check these details before you open a PR
This PR adds/fixes
Fixes an issue where peek-bot can't take a screenshot as seen in #822. This turns out to be caused by elements not being visible when the screenshot function is called (see this).
The script now gets the screenshot elements in a different way and check that they are visible before screenshotting them.
Notes
This closes #828