Add controls to set custom size. Add new preference storage model #16

devindi · 2018-10-01T20:17:40Z

No description provided.

codecov · 2018-10-09T20:52:23Z

Codecov Report

Merging #16 into master will decrease coverage by 2.29%.
The diff coverage is 3.03%.

@@            Coverage Diff             @@
##             master     #16     +/-   ##
==========================================
- Coverage     24.79%   22.5%   -2.3%     
  Complexity       61      61             
==========================================
  Files            52      64     +12     
  Lines          1105    1231    +126     
  Branches        137     149     +12     
==========================================
+ Hits            274     277      +3     
- Misses          801     923    +122     
- Partials         30      31      +1

Impacted Files	Coverage Δ	Complexity Δ
.../com/devindi/wallpaper/model/map/MapAreaManager.kt	`72.72% <ø> (ø)`	`10 <0> (ø)`	⬇️
.../devindi/wallpaper/settings/size/SizeViewHolder.kt	`0% <0%> (ø)`	`0 <0> (?)`
...devindi/wallpaper/misc/AfterTextChangedListener.kt	`0% <0%> (ø)`	`0 <0> (?)`
...evindi/wallpaper/settings/model/SettingsManager.kt	`0% <0%> (ø)`	`0 <0> (?)`
...a/com/devindi/wallpaper/settings/model/IntField.kt	`0% <0%> (ø)`	`0 <0> (?)`
...java/com/devindi/wallpaper/misc/NonNullLiveData.kt	`0% <0%> (ø)`	`0 <0> (?)`
...wallpaper/settings/size/edit/EditSizeController.kt	`0% <0%> (ø)`	`0 <0> (?)`
...om/devindi/wallpaper/settings/model/StringField.kt	`0% <0%> (ø)`	`0 <0> (?)`
...m/devindi/wallpaper/model/map/MapImageGenerator.kt	`0% <0%> (ø)`	`0 <0> (?)`
...indi/wallpaper/misc/SimpleSeekBarChangeListener.kt	`0% <0%> (ø)`	`0 <0> (?)`
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd63e2...7b9415c. Read the comment docs.

devindi · 2018-10-13T20:52:08Z

app/src/main/java/com/devindi/wallpaper/settings/SettingsAdapter.kt

+import com.devindi.wallpaper.settings.size.SizeViewHolder
+import com.devindi.wallpaper.source.OnItemClickListener
+
+class SettingsAdapter(private val clickListener: OnItemClickListener) : RecyclerView.Adapter<RecyclerView.ViewHolder>() {


⚠️ Exceeded max line length (100) (cannot be auto-corrected)

devindi · 2018-10-13T20:52:09Z

app/src/main/java/com/devindi/wallpaper/settings/SettingsAdapter.kt

+        }
+
+    override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): RecyclerView.ViewHolder {
+        val view = LayoutInflater.from(parent.context).inflate(R.layout.settings_simple_item, parent, false)


⚠️ Exceeded max line length (100) (cannot be auto-corrected)

devindi · 2018-10-13T20:52:09Z

app/src/main/java/com/devindi/wallpaper/settings/SettingsViewModel.kt

+import com.devindi.wallpaper.settings.model.SettingsField
+import com.devindi.wallpaper.settings.model.SettingsManager
+
+class SettingsViewModel(private val settingsManager: SettingsManager): ViewModel() {


⚠️ Missing spacing before “:”

devindi · 2018-10-13T20:52:11Z

app/src/main/java/com/devindi/wallpaper/settings/model/SettingsManager.kt

+
+    private val map = HashMap<String, SettingsField<*>>()
+    private val fieldLive = MutableLiveData<String>()
+    private val sharedPreferenceChangeListener = SharedPreferences.OnSharedPreferenceChangeListener {


⚠️ Exceeded max line length (100) (cannot be auto-corrected)

devindi · 2018-10-13T20:52:11Z

app/src/main/java/com/devindi/wallpaper/settings/model/SettingsManager.kt

+        storage.registerOnSharedPreferenceChangeListener(sharedPreferenceChangeListener)
+    }
+
+    fun getIntField(key: String) : IntField {


⚠️ Unexpected spacing before “:”

devindi · 2018-10-13T20:52:12Z

app/src/main/java/com/devindi/wallpaper/settings/model/SettingsManager.kt

+        return map[key] as IntField
+    }
+
+    fun fieldChange() : LiveData<String> = fieldLive


⚠️ Unexpected spacing before “:”

devindi · 2018-10-13T20:52:12Z

app/src/main/java/com/devindi/wallpaper/settings/model/SettingsManager.kt

+
+    fun fieldChange() : LiveData<String> = fieldLive
+
+    private fun addField(field : SettingsField<*>) {


⚠️ Unexpected spacing before “:”

Add controls to set custom size. Add new preference storage model

dbdfb3a

devindi force-pushed the custom_size branch from d54152e to dbdfb3a Compare October 9, 2018 19:51

Fix after rebase

f22b9ee

devindi added 2 commits October 10, 2018 22:10

Add new image generator

9b0df37

Improve settings screen

264baa3

devindi commented Oct 13, 2018

View reviewed changes

Code style

7b9415c

devindi force-pushed the custom_size branch from 5f08a7b to 7b9415c Compare October 16, 2018 18:39

devindi merged commit eb40a23 into master Oct 16, 2018

devindi mentioned this pull request Oct 23, 2018

Custom wallpaper size #4

Closed

devindi deleted the custom_size branch October 23, 2018 19:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add controls to set custom size. Add new preference storage model #16

Add controls to set custom size. Add new preference storage model #16

devindi commented Oct 1, 2018

codecov bot commented Oct 9, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited


		fun fieldChange() : LiveData<String> = fieldLive

		private fun addField(field : SettingsField<*>) {

Add controls to set custom size. Add new preference storage model #16

Add controls to set custom size. Add new preference storage model #16

Conversation

devindi commented Oct 1, 2018

codecov bot commented Oct 9, 2018 • edited

Codecov Report

devindi Oct 13, 2018 • edited

Choose a reason for hiding this comment

devindi Oct 13, 2018 • edited

Choose a reason for hiding this comment

devindi Oct 13, 2018 • edited

Choose a reason for hiding this comment

devindi Oct 13, 2018 • edited

Choose a reason for hiding this comment

devindi Oct 13, 2018 • edited

Choose a reason for hiding this comment

devindi Oct 13, 2018 • edited

Choose a reason for hiding this comment

devindi Oct 13, 2018 • edited

Choose a reason for hiding this comment

codecov bot commented Oct 9, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited

devindi Oct 13, 2018 •

edited