Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plugin & pdf_extracter #3

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Added plugin & pdf_extracter #3

merged 2 commits into from
Mar 28, 2024

Conversation

zhs007
Copy link
Contributor

@zhs007 zhs007 commented Mar 26, 2024

代码比较粗糙,尽量没有太多的改你的结构,几个要点:

  1. 感觉上,只要是一个有读权限的oss上放文件就可以了,至于文件如何上传到oss上,可以放外部来实现。不确定任意一个url是否都能访问,我只试了自己的oss。
  2. TextContent 结构应该要更复杂,或者再建一个,我感觉这块接口需要重构一下,所以简单的在 TextContent 里处理了,json结构上需要是个array,所以跳过了 Marshal 。
  3. Plugin放header里,结构上也会需要更复杂一些,我简单加了一下而已。

测试代码能过。

希望对你有帮助。

@devinyf devinyf changed the base branch from main to plugin_call March 28, 2024 11:50
@devinyf devinyf merged commit c798180 into devinyf:plugin_call Mar 28, 2024
1 of 2 checks passed
@devinyf
Copy link
Owner

devinyf commented Mar 28, 2024

感谢,我想新添加一个 Content 类型来处理需要文件上传的case,所以此pr先临时 merge 到一个单独的功能分支中, 等后续修改完成再合并到主分支

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants