Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Add machinery for custom memory allocators and MPI #1764

Merged
merged 7 commits into from Oct 2, 2021

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #1764 (8d6c8d6) into master (74e7859) will decrease coverage by 27.08%.
The diff coverage is 76.92%.

❗ Current head 8d6c8d6 differs from pull request most recent head e116845. Consider uploading reports for the commit e116845 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1764       +/-   ##
===========================================
- Coverage   89.52%   62.43%   -27.09%     
===========================================
  Files         209      209               
  Lines       33879    33927       +48     
  Branches     4404     4406        +2     
===========================================
- Hits        30330    21183     -9147     
- Misses       3050    12133     +9083     
- Partials      499      611      +112     
Impacted Files Coverage Δ
devito/core/arm.py 43.33% <0.00%> (-1.50%) ⬇️
devito/types/grid.py 86.16% <ø> (-6.29%) ⬇️
devito/core/gpu.py 73.43% <20.00%> (-22.86%) ⬇️
devito/data/allocators.py 66.29% <66.66%> (-12.53%) ⬇️
devito/passes/iet/definitions.py 74.48% <71.05%> (-12.97%) ⬇️
devito/core/cpu.py 87.05% <100.00%> (-12.95%) ⬇️
devito/mpi/routines.py 95.68% <100.00%> (+0.03%) ⬆️
devito/passes/iet/engine.py 95.41% <100.00%> (+0.56%) ⬆️
devito/passes/iet/mpi.py 99.37% <100.00%> (+<0.01%) ⬆️
tests/test_gpu_openmp.py 4.51% <0.00%> (-93.79%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e7859...e116845. Read the comment docs.

@FabioLuporini FabioLuporini force-pushed the generalize-mpi-modes branch 3 times, most recently from bd16d58 to 787bf1f Compare October 1, 2021 08:54

* ALLOC_GUARD: Only used in so-called "develop mode", to trigger SIGSEGV as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop-mode or develop_mode just for 'grepping' homogeneity

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests needed in this PR?

@FabioLuporini
Copy link
Contributor Author

Any tests needed in this PR?

Basically no because I'm not adding any new functionalities

Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any easy way to add a test/example of custom allocator?

@FabioLuporini
Copy link
Contributor Author

Any easy way to add a test/example of custom allocator?

not really... we could create a mapping for one of the existing ones... but what for?

@FabioLuporini
Copy link
Contributor Author

as in, just to clarify. All the code added by this PR is already tested automatically by the current tests, as the execution flow goes through all the touched classes and functions. That's why I wrote above that we're basically good to go

@@ -590,13 +590,13 @@ def _bounds_glb_to_loc(cls, dec, m, M):

def __subdomain_finalize__(self, dimensions, shape, distributor=None, **kwargs):
"""
Must be overridded by subclasses.
Must be overridden by subclasses.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgebisbas as promised, fixed it here

@FabioLuporini FabioLuporini merged commit e663ffe into master Oct 2, 2021
@FabioLuporini FabioLuporini deleted the generalize-mpi-modes branch October 2, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants