New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler: Add machinery for custom memory allocators and MPI #1764
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1764 +/- ##
===========================================
- Coverage 89.52% 62.43% -27.09%
===========================================
Files 209 209
Lines 33879 33927 +48
Branches 4404 4406 +2
===========================================
- Hits 30330 21183 -9147
- Misses 3050 12133 +9083
- Partials 499 611 +112
Continue to review full report at Codecov.
|
bd16d58
to
787bf1f
Compare
|
||
* ALLOC_GUARD: Only used in so-called "develop mode", to trigger SIGSEGV as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
develop-mode or develop_mode just for 'grepping' homogeneity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any tests needed in this PR?
Basically no because I'm not adding any new functionalities |
787bf1f
to
e116845
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any easy way to add a test/example of custom allocator?
not really... we could create a mapping for one of the existing ones... but what for? |
as in, just to clarify. All the code added by this PR is already tested automatically by the current tests, as the execution flow goes through all the touched classes and functions. That's why I wrote above that we're basically good to go |
@@ -590,13 +590,13 @@ def _bounds_glb_to_loc(cls, dec, m, M): | |||
|
|||
def __subdomain_finalize__(self, dimensions, shape, distributor=None, **kwargs): | |||
""" | |||
Must be overridded by subclasses. | |||
Must be overridden by subclasses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georgebisbas as promised, fixed it here
No description provided.