Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sympy: proper version check #1769

Merged
merged 2 commits into from Oct 5, 2021
Merged

sympy: proper version check #1769

merged 2 commits into from Oct 5, 2021

Conversation

mloubout
Copy link
Contributor

@mloubout mloubout commented Oct 5, 2021

No description provided.

@mloubout mloubout added the API api (symbolics, types, ...) label Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #1769 (c598d78) into master (a7d3b38) will decrease coverage by 1.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1769      +/-   ##
==========================================
- Coverage   89.47%   87.91%   -1.57%     
==========================================
  Files         208      203       -5     
  Lines       33936    33390     -546     
  Branches     4408     4375      -33     
==========================================
- Hits        30365    29354    -1011     
- Misses       3074     3523     +449     
- Partials      497      513      +16     
Impacted Files Coverage Δ
devito/finite_differences/elementary.py 94.61% <100.00%> (+0.01%) ⬆️
examples/seismic/acoustic/wavesolver.py 97.29% <100.00%> (-2.71%) ⬇️
tests/test_adjoint.py 26.66% <0.00%> (-73.34%) ⬇️
examples/seismic/tti/operators.py 53.94% <0.00%> (-43.16%) ⬇️
examples/seismic/self_adjoint/operators.py 58.46% <0.00%> (-41.54%) ⬇️
examples/seismic/viscoacoustic/operators.py 59.49% <0.00%> (-40.51%) ⬇️
examples/seismic/elastic/elastic_example.py 47.22% <0.00%> (-30.56%) ⬇️
...mples/seismic/viscoelastic/viscoelastic_example.py 47.22% <0.00%> (-30.56%) ⬇️
examples/seismic/tti/wavesolver.py 68.59% <0.00%> (-29.76%) ⬇️
...les/seismic/viscoacoustic/viscoacoustic_example.py 45.00% <0.00%> (-25.00%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d3b38...c598d78. Read the comment docs.

@mloubout mloubout force-pushed the sympyver branch 2 times, most recently from e84817a to 7ee68da Compare October 5, 2021 13:20
Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API api (symbolics, types, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants