Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Further minor tweaks #1796

Merged
merged 5 commits into from Nov 10, 2021
Merged

compiler: Further minor tweaks #1796

merged 5 commits into from Nov 10, 2021

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

v = self.writes.setdefault(e.lhs.function, [])
mode = 'WI' if e.is_Increment else 'W'
v.append(TimedAccess(e.lhs, mode, i, e.ispace))
if q_terminal(e.lhs):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply, this now behaves just like reads a few lines above

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1796 (a25c8c6) into master (6159e32) will increase coverage by 7.47%.
The diff coverage is 80.00%.

❗ Current head a25c8c6 differs from pull request most recent head 56081ac. Consider uploading reports for the commit 56081ac to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1796      +/-   ##
==========================================
+ Coverage   78.12%   85.60%   +7.47%     
==========================================
  Files         209      204       -5     
  Lines       34131    33523     -608     
  Branches     4446     4387      -59     
==========================================
+ Hits        26665    28697    +2032     
+ Misses       6923     4309    -2614     
+ Partials      543      517      -26     
Impacted Files Coverage Δ
devito/ir/support/utils.py 88.07% <50.00%> (-1.84%) ⬇️
devito/symbolics/extended_sympy.py 95.89% <77.77%> (+5.05%) ⬆️
devito/ir/support/basic.py 91.92% <80.00%> (+0.22%) ⬆️
devito/ir/iet/nodes.py 92.53% <100.00%> (+3.24%) ⬆️
devito/symbolics/printer.py 74.11% <100.00%> (+1.49%) ⬆️
tests/test_pickle.py 99.55% <100.00%> (+16.62%) ⬆️
tests/test_gpu_openmp.py 4.51% <0.00%> (-87.01%) ⬇️
tests/test_adjoint.py 26.66% <0.00%> (-73.34%) ⬇️
examples/seismic/tti/operators.py 53.94% <0.00%> (-43.16%) ⬇️
examples/seismic/self_adjoint/operators.py 58.46% <0.00%> (-41.54%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6159e32...56081ac. Read the comment docs.

@mloubout mloubout merged commit 3d0b26b into master Nov 10, 2021
@FabioLuporini FabioLuporini deleted the tweaks-1111 branch December 11, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants