compiler: Patch iteration space scheduling #1898
Conversation
FabioLuporini
force-pushed
the
hotfix-issue-1897
branch
from
884a13d
to
bc94a6f
Compare
| def test_issue_1897(self): | ||
| grid = Grid(shape=(11, 11, 11)) | ||
|
|
||
| v = VectorTimeFunction(name='v', grid=grid, time_order=1, space_order=4) |
There was a problem hiding this comment.
Orders can be dropped..space_order, time_order
Codecov Report
@@ Coverage Diff @@
## master #1898 +/- ##
==========================================
- Coverage 89.63% 89.63% -0.01%
==========================================
Files 210 210
Lines 35265 35272 +7
Branches 5319 5319
==========================================
+ Hits 31611 31616 +5
- Misses 3161 3162 +1
- Partials 493 494 +1
Continue to review full report at Codecov.
|
| @@ -84,7 +84,7 @@ class Schedule(QueueStateful): | |||
|
|
|||
| @timed_pass(name='schedule') | |||
| def process(self, clusters): | |||
| return self._process_fdta(clusters, 1) | |||
| return self._process_fatd(clusters, 1) | |||
There was a problem hiding this comment.
not sure if you are kidding? :-p
First Divide then apply
First apply then divide
It is such as small and nice fix though...like a typo
There was a problem hiding this comment.
Not kidding was just wondering if was intentional to have fdta or if was meant to be fatd from the beginning but wasn't noticed. anyway all good
There was a problem hiding this comment.
fatd leads to a fundamental change in the algorithm behavior, so no, it was not a typo but rather an actual bug
No description provided.