Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Add FAQ page (lifted from the wiki) #1976

Merged
merged 1 commit into from Aug 3, 2022
Merged

misc: Add FAQ page (lifted from the wiki) #1976

merged 1 commit into from Aug 3, 2022

Conversation

FabioLuporini
Copy link
Contributor

@FabioLuporini FabioLuporini commented Jul 26, 2022

if we do this, we should also update the FAQ link in the wiki (and drop the page there)

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #1976 (774720c) into master (1d98eb1) will increase coverage by 0.02%.
The diff coverage is 87.37%.

❗ Current head 774720c differs from pull request most recent head dd1aac3. Consider uploading reports for the commit dd1aac3 to get more accurate results

@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
+ Coverage   87.88%   87.90%   +0.02%     
==========================================
  Files         213      214       +1     
  Lines       36196    36232      +36     
  Branches     5449     5465      +16     
==========================================
+ Hits        31810    31849      +39     
+ Misses       3877     3868       -9     
- Partials      509      515       +6     
Impacted Files Coverage Δ
tests/test_gpu_common.py 1.50% <0.00%> (ø)
tests/test_operator.py 97.69% <ø> (-0.14%) ⬇️
devito/ir/iet/visitors.py 81.79% <80.85%> (+0.16%) ⬆️
devito/tools/utils.py 82.79% <82.92%> (+1.21%) ⬆️
devito/types/parallel.py 83.95% <83.33%> (+1.11%) ⬆️
devito/passes/iet/definitions.py 84.12% <86.15%> (+0.16%) ⬆️
devito/types/basic.py 94.72% <87.87%> (+0.46%) ⬆️
devito/types/object.py 92.38% <92.38%> (ø)
devito/types/array.py 96.00% <95.00%> (+4.19%) ⬆️
devito/finite_differences/differentiable.py 95.19% <100.00%> (-0.37%) ⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the rich diff some of them do not link to the place where the question is answered.
e.g.: Do Devito Operators release the GIL when executing C code?

@FabioLuporini
Copy link
Contributor Author

If you look at the rich diff some of them do not link to the place where the question is answered.
e.g.: Do Devito Operators release the GIL when executing C code?

same in the wiki?

@georgebisbas
Copy link
Contributor

If you look at the rich diff some of them do not link to the place where the question is answered.
e.g.: Do Devito Operators release the GIL when executing C code?

same in the wiki?

As I see, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants