compiler: Do block with partial data reuse #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2094 +/- ##
=======================================
Coverage 87.80% 87.80%
=======================================
Files 221 221
Lines 38657 38665 +8
Branches 5000 5000
=======================================
+ Hits 33941 33951 +10
+ Misses 4165 4164 -1
+ Partials 551 550 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
EdCaunt
approved these changes
Mar 29, 2023
georgebisbas
approved these changes
Mar 29, 2023
| @@ -196,6 +196,10 @@ def callback(self, clusters, prefix): | |||
| if self._has_short_trip_count(d): | |||
| return clusters | |||
|
|
|||
| # Pointless if there's no data reuse | |||
| if all(not self._has_data_reuse(c) for c in clusters): | |||
There was a problem hiding this comment.
nit: Slight preference for but not important
Suggested change
| if all(not self._has_data_reuse(c) for c in clusters): | |
| if not any(self._has_data_reuse(c) for c in clusters): |
There was a problem hiding this comment.
agree, I will change it in a subsequent branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.