Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Add shift and fd order option to all FD operators: #2258

Merged
merged 2 commits into from Nov 13, 2023
Merged

Conversation

mloubout
Copy link
Contributor

@mloubout mloubout commented Nov 3, 2023

Add options so can do things like div(u, order=so, shift=.5) for left/right laplacian

@mloubout mloubout added the API api (symbolics, types, ...) label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2258 (8b1ce77) into master (39a8486) will increase coverage by 0.05%.
The diff coverage is 97.85%.

@@            Coverage Diff             @@
##           master    #2258      +/-   ##
==========================================
+ Coverage   86.88%   86.94%   +0.05%     
==========================================
  Files         229      229              
  Lines       42033    42109      +76     
  Branches     7760     7777      +17     
==========================================
+ Hits        36521    36612      +91     
+ Misses       4871     4854      -17     
- Partials      641      643       +2     
Files Coverage Δ
devito/finite_differences/differentiable.py 94.27% <100.00%> (+0.06%) ⬆️
tests/test_derivatives.py 100.00% <100.00%> (ø)
tests/test_tensors.py 95.56% <100.00%> (+0.87%) ⬆️
devito/finite_differences/operators.py 64.28% <87.50%> (+7.14%) ⬆️
devito/types/tensor.py 92.59% <93.33%> (+7.09%) ⬆️

@mloubout mloubout changed the title api: add shift and fd order option to all FD operators: api: Add shift and fd order option to all FD operators: Nov 13, 2023
Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial, thanks

@mloubout mloubout merged commit b2b42b8 into master Nov 13, 2023
31 checks passed
@mloubout mloubout deleted the fdop-kwargs branch November 13, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API api (symbolics, types, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants