Themes/styles are out of hand

[gruelingpine185]

As of now, Rungeon uses 6 different themes (not including the default theme). Certain elements are given colors and styling specific to themes and it creates problems. For example, when implementing new pages, I find myself switching between themes (or working in one that I wasn't the day before due to testing). This makes it difficult when dealing with CSS and colors for obvious reasons. Not to mention, the 404 page has its own theme and styling, which is very different from the game and what I'm currently working on on my fork.

This also goes with the JS side of things. It took me a literal 10-15mins to find and fix the few broken links JS was manipulating in the public/main.js file. I can only imagine how long it'll take to create a new stage (for both myself and for new contributors). This codebase needs a complete makeover. Rungeon's future depends on it.

Proposal

• Stages should be organized in a manner that is both easy to read, write, and manipulate for both contributors and Rungeon. (I'm thinking more along the lines of JS objects or JSON to tackle this)
• Better documentation/comments. Very Important.
• Halt on all work on themes until a set style has been established and Option to go back to default theme #49 is patched. We need a consistent development area.
• Resolve CSS element stylings. For example, <a>...</a> are for links. Why are they styled as if they are buttons?

These are a few things that stood out, but there are many more opportunities for improvement.

See Also

• New Theme Handling #121
• Theme Popup onclick #117
• Option to go back to default theme #49
• Better way to control themes #114
• Styles not applied to rungeon.html when using npm #134

[gruelingpine185]

@devkennyy do you mind creating another branch where these issues can be addressed? It'll be great if everyone can see and work on the repo at one place rather than messing with forks. I'll do what I can on my fork and PR onto that branch

[devkennyy]

Not to mention, the 404 page has its own theme and styling, which is very different from the game and what I'm currently working on on my fork.

The 404 page was automatically created by Firebase and definitely needs work.

This codebase needs a complete makeover. Rungeon's future depends on it.

I had no idea how broken it really was. Should we remove themes from the live site in the mean time?

Do you mind creating another branch where these issues can be addressed?

I've created a new branch under the name 'themes'.

[gruelingpine185]

I'd say keep the themes on the live site for now. If we end up messing up the development part of it, we can always get the original source files back without dealing with commit history. We should work towards a stable version where we can have all of these issues resolved. Once that's in place then we can see about more features.

[devkennyy]

• #117 theme popup onclick #132
• New Theme Handling #121
• Ability to use default theme #119
  ..have all been merged.

[devkennyy]

Since the themes don't work on the master branch, shall I add a 'in development' note or disable the theme button?

[devkennyy]

Theme css selectors need to be changed

There are existing styles for the theme popup titles, the names are just incorrect

Themes only apply if you select the default one first

Most likely an issue with how we are checking for duplicates.

[gruelingpine185]

An 'in development' note would be awesome