Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed button text and visibility #138

Closed
wants to merge 1 commit into from
Closed

changed button text and visibility #138

wants to merge 1 commit into from

Conversation

staranbeer
Copy link
Contributor

changed the continue button text and brightness

@gruelingpine185
Copy link
Collaborator

gruelingpine185 commented Jul 25, 2022

thank you for your contribution! It's appreciated :)

@devkennyy and myself are trying to resolve the theme issues #116. Because of the transformation to an in development theme handling system and new stage handling system, the main branch has some things that need to be addressed before we can safely continue.

@staranbeer
Copy link
Contributor Author

sure! let me know if there is a way i can help with whatever you're currently working on. 😉

@gruelingpine185 gruelingpine185 added the status: postponed Awaiting repo changes before further action label Jul 25, 2022
@gruelingpine185
Copy link
Collaborator

@staranbeer So here is what I'd like for you to do. Do you mind updating your PR to conform to the changes on the stage-remake branch? This branch is the one with the new systems that will eventually replace the ones on the main branch. Since you are working with buttons, could you also style the buttons to look like the ones at https://rungeon.live/rungeon?

@staranbeer
Copy link
Contributor Author

so instead of the code i edited on the main branch i should make a commit to the stage-remake branch with the changes? and by styling the buttons you mean add css to the buttons on the stage-remake branch? and if so shouldn't we just copy paste the styles from the main branch?

@gruelingpine185
Copy link
Collaborator

There are a few changes on the stage-remake branch that may affect the appearance of elements and therefore I wouldn't recommend copy/pasting changes from the main branch. To answer the first question, yes you could make a commit with the changes you made and revise them to fit with the already existing styles on the stage-remake branch.

@gruelingpine185 gruelingpine185 added scope: UI Addressing UX changes and improvements to user interface status: work in progress Applied if a PR has been assigned and removed status: postponed Awaiting repo changes before further action labels Jul 25, 2022
@staranbeer staranbeer closed this Jul 26, 2022
@staranbeer staranbeer deleted the button branch July 26, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: UI Addressing UX changes and improvements to user interface status: work in progress Applied if a PR has been assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants