#117 theme popup onclick #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Themes are one step closer to not being out of hand 😅 |
This was referenced Jul 25, 2022
Closed
devkennyy
pushed a commit
that referenced
this pull request
Apr 10, 2023
* Re-added popup toggling when setting theme * Fixed popup opening when body clicked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Okay. Removed some of the changes made in PR #104 because they were already implemented in #78.
(#104 also brought back the error referenced in #93)
Fixed bug where the popup would open when the body is clicked. The click handler was not up to date with the new CSS-only popup hiding.
Re-added the line
toggleThemePopup()that was lost when themes.js was created.Changes
Removed redundancy.
Fixed the popup bug.
Re-added popup toggling when the theme is changed.
Solves
Closes [#117]