Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure package targets netstandard2.0 #10

Closed
kzu opened this issue Sep 27, 2022 · 0 comments · Fixed by #11
Closed

Make sure package targets netstandard2.0 #10

kzu opened this issue Sep 27, 2022 · 0 comments · Fixed by #11

Comments

@kzu
Copy link
Contributor

kzu commented Sep 27, 2022

Since the package is just build targets, it ends up as a package that
doesn't target any specific target framework. This is problematic
for nuget restore, which won't bring anything from this when it's
referenced transitively from a TF-targeting package (i.e. Merq).

So, make sure our targets also target NS2, so the package is flagged
as TF-specific too (although general enough API-wise to target anything
MS.Extensions.DI targets too.

kzu added a commit that referenced this issue Sep 27, 2022
Fixes issues when referencing transitively, namely,
nothing is restored :(

Fixes #10
kzu added a commit that referenced this issue Sep 27, 2022
Fixes issues when referencing transitively, namely,
nothing is restored :(

Fixes #10
@kzu kzu closed this as completed in #11 Sep 27, 2022
kzu added a commit that referenced this issue Sep 27, 2022
Fixes issues when referencing transitively, namely,
nothing is restored :(

Fixes #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant