Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never report warning for missing AddServices() in test projects #47

Closed
kzu opened this issue Dec 6, 2022 · 0 comments · Fixed by #48
Closed

Never report warning for missing AddServices() in test projects #47

kzu opened this issue Dec 6, 2022 · 0 comments · Fixed by #48

Comments

@kzu
Copy link
Contributor

kzu commented Dec 6, 2022

Test projects have the IsTestProject=true via the required dependency on Microsoft.NET.Test.Sdk.

We can leverage that property in the analyzer to never report this warning which is intended for
the actual hosting projects.
kzu added a commit that referenced this issue Dec 6, 2022
@kzu
Don't report warning for missing AddServices() in test projects
39f3eac 
Test projects have the IsTestProject=true via the required dependency on Microsoft.NET.Test.Sdk.

We leverage that property in the analyzer to never report this warning which is intended for
the actual hosting projects.

Closes #47
@kzu kzu mentioned this issue Dec 6, 2022
Merged
@kzu kzu closed this as completed in #48 Dec 6, 2022
kzu added a commit that referenced this issue Dec 6, 2022
@kzu
Don't report warning for missing AddServices() in test projects
fbccbaa 
Test projects have the IsTestProject=true via the required dependency on Microsoft.NET.Test.Sdk.

We leverage that property in the analyzer to never report this warning which is intended for
the actual hosting projects.

Closes #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kzu