New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If compilation isn't successful, incremental generator fails #51

Closed

kzu opened this issue Dec 13, 2022 · 0 comments · Fixed by #52

Labels

bug

Contributor

kzu commented Dec 13, 2022

Say you have code that doesn't fully compile. Generators are invoked nevertheless.

In this scenario, the Compilation.IsSymbolAccessibleWithin is throwing at
https://github.com/dotnet/roslyn/blob/9fef96ff1194f686993293c7971802216eb75a26/src/Compilers/Core/Portable/Compilation/Compilation.cs#L1626. I was expecting a false return value instead 🤷‍♂️, so we should account
for that.

The text was updated successfully, but these errors were encountered:

kzu added the bug label

kzu added a commit that referenced this issue


          Generator shouldn't fail for unsuccessful compilation

9765d37

In this scenario, the Compilation.IsSymbolAccessibleWithin is throwing at
https://github.com/dotnet/roslyn/blob/9fef96ff1194f686993293c7971802216eb75a26/src/Compilers/Core/Portable/Compilation/Compilation.cs#L1626.

We account for that by providing our wrapping extension method that catches the exception and returns false instead (what we were expecting to get anyway).

Closes #51

kzu mentioned this issue

Generator shouldn't fail for unsuccessful compilation #52

Merged

kzu closed this as completed in #52

kzu added a commit that referenced this issue


          Generator shouldn't fail for unsuccessful compilation

ee17c10

In this scenario, the Compilation.IsSymbolAccessibleWithin is throwing at
https://github.com/dotnet/roslyn/blob/9fef96ff1194f686993293c7971802216eb75a26/src/Compilers/Core/Portable/Compilation/Compilation.cs#L1626.

We account for that by providing our wrapping extension method that catches the exception and returns false instead (what we were expecting to get anyway).

Closes #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment