Replace ServiceAttribute inclusion via targets with source generator #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzu
force-pushed
the
dev/attrgenerator
branch
from
0f9f511
to
faf50c6
Compare
kzu
force-pushed
the
dev/attrgenerator
branch
2 times, most recently
from
b7edfab
to
53e5b2d
Compare
The brokenness on the transitivity of contentFiles is tricky to overcome, and proved more complicated to also maintain and test in various scenarios than simply reading the same project property we have now, and skip adding the static contents of the file via the source generator itself instead. Adding a way to exclude the attribute is superfluous, so we just remove that option. Users can always have their own attribute in any namespace. Hopefully one day the [Service] attribute does come built-in the DI asm. Fixes #12
kzu
force-pushed
the
dev/attrgenerator
branch
from
53e5b2d
to
5d85f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brokenness on the transitivity of contentFiles is tricky to overcome, and proved more complicated to also maintain and test in various scenarios than simply reading the same project property we have now, and skip adding the static contents of the file via the source generator itself instead.
Renamed IncludeServiceAttribute to AddServiceAttribute for consistency. Added backs compat just in case.
Fixes #12