Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README to NuGet package #1194

Closed
loic-sharma opened this issue Jul 31, 2021 · 4 comments
Closed

Add README to NuGet package #1194

loic-sharma opened this issue Jul 31, 2021 · 4 comments

Comments

@loic-sharma
Copy link

Hello!

I am from the NuGet team at Microsoft. We recently introduced support for embedding READMEs into NuGet packages (blog, docs), and we plan to place these READMEs front and center on nuget.org. Would you be willing to accept a contribution to add an embedded READMEs to the Moq package?

@stakx
Copy link
Contributor

stakx commented Aug 1, 2021

Hi @loic-sharma. Sounds great!

One thing, Moq packages are potentially released from two different repositories: this one here (moq/moq4), and moq/moq. I suppose the README.md from the package last pushed "wins"? Or the one from the latest version?

We'd need to make sure that if we actually do publish from both repositories, the Readme section on NuGet won't randomly change.

/cc @kzu (for the moq/moq repo)

@loic-sharma
Copy link
Author

Oh I didn't know y'all were working on a new version of Moq! READMEs are version-specific. In other words, if V4 has README foo and V5 has README bar, we will show foo if you browse V4 and bar if you browse V5. I'll send pull requests to both repositories! :)

@stakx
Copy link
Contributor

stakx commented Aug 1, 2021

I see, and since NuGet displays the latest version by default, one would typically see the bar README once Moq v5 has been officially released. Makes sense! 👍

@stakx
Copy link
Contributor

stakx commented Feb 12, 2022

I'm closing this issue as it has gone stale. @loic-sharma (or anyone else), if you're still interested in adding a README to the Moq NuGet package, feel free to submit a PR.

@stakx stakx closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants