Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Castle.Core 4.1.0 #375

Closed
natemcmaster opened this issue Jun 15, 2017 · 2 comments
Closed

Upgrade to Castle.Core 4.1.0 #375

natemcmaster opened this issue Jun 15, 2017 · 2 comments

Comments

@natemcmaster
Copy link

Coming soon: the launch of .NET Core 2.0 adds NuGet improvements which includes warnings about misconfigured packages. Castle.Core 4.0.0 had a such an issue (see castleproject/Core#239) that is resolved in 4.1.0. Until Moq upgrades, .NET Core 2.0 projects will see this warning during restore when the reference Moq 4.7.25.

warning NU1603: Castle.Core 4.0.0 depends on System.ComponentModel.TypeConverter (>= 4.0.1) but System.ComponentModel.TypeConverter 4.0.1 was not found. An approximate best match of System.ComponentModel.TypeConverter 4.1.0 was resolved.
@stakx
Copy link
Contributor

stakx commented Jun 15, 2017 •
edited

Hi @natemcmaster, the update to Castle Core 4.1.0 has already happened on the develop branch (see commit e67faa9), so it will be in the next NuGet release (version >4.7.25) of Moq.

I've also updated the Microsoft / System package references to the latest versions (see commit 77db8c8), so hopefully those warnings you're seeing will disappear.

@natemcmaster
Copy link
Author

Awesome sauce. 👏

@stakx stakx closed this as completed Jun 18, 2017
@evildour evildour mentioned this issue Aug 17, 2017
Closed
This was referenced Aug 19, 2017
Closed
Closed
MIchaelMainer added a commit to microsoftgraph/msgraph-sdk-dotnet that referenced this issue Jan 16, 2018
@MIchaelMainer
VS 2017 - Updated Moq reference as some environments are hitting devl…
748d4fa 
…ooped/moq#375
@MIchaelMainer MIchaelMainer mentioned this issue Jan 16, 2018
Merged
MIchaelMainer added a commit to microsoftgraph/msgraph-sdk-dotnet that referenced this issue Jan 19, 2018
@MIchaelMainer
Dev Reporting api (#228)
9558882 
* Added Reports API support. https://developer.microsoft.com/en-us/graph/docs/api-reference/v1.0/resources/report

* Added release notes and bumped version for the Report API update.

* Updated the /// comments to improve IntelliSense doc coverage.

* Added an ad hoc test for Reports API.

* Disabled test case for CI.

* VS 2017 - Updated Moq reference as some environments are hitting devlooped/moq#375

* Removed duplicate project reference from m.g.c.test.csproj; updated msbuild threw an error on this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stakx @natemcmaster