Expression execution during override detection must not stop setup from being added #1032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix #1031.
This is not the best possible solution. It would be preferable to require matchers to carry an easily discoverable
[Matcher]
attribute, such that expressions don't have to be compiled and executed anymore just to discover whether a matcher ran. (Requiring that attribute would be a breaking change, which perhaps we can avoid for a little while longer.)