Add .NET Framework reference assembly packages #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it possible to build Moq on machines using `dotnet` even when Visual Studio is not installed. (Reference assemblies for the .NET Framework used to be only available on your machine if you installed Visual Studio, but now they have been made available through a NuGet package.)
stakx
force-pushed
the
netfx-reference-assemblies
branch
from
0b72076
to
5502c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it possible to build Moq on machines using
dotneteven when Visual Studio is not installed.(Reference assemblies for the .NET Framework used to be only available on your machine if you installed Visual Studio, but now they have been made available through a NuGet package.)
Things left to do:
Check whether builds still work with Visual Studio.
I remember build warnings in another project saying that you don't need to explicitly add the reference assembly package to your project because the toolchain adds it implicitly. However not all toolchains do this, so figure out how to get rid of that warning without completely undoing the work in this PR.