Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid AmbiguousMatchException when interface has indexer besides property #1131

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

mujdatdinc
Copy link

@mujdatdinc mujdatdinc commented Jan 16, 2021

fix(vb): Indexer properties raise AmbiguousMatchException.

Fixes #1129.

Copy link
Contributor

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mujdatdinc! There are a few things that need attention. Once those are fixed, we should be ready to merge.

tests/Moq.Tests.VisualBasic/IssueReports.vb Outdated Show resolved Hide resolved
tests/Moq.Tests.VisualBasic/IssueReports.vb Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tests/Moq.Tests.VisualBasic/IssueReports.vb Outdated Show resolved Hide resolved
@stakx stakx added this to the 4.16.1 milestone Jan 17, 2021
@stakx stakx changed the title issu #1129 Avoid AmbiguousMatchException when interface has indexer besides property Jan 17, 2021
@stakx stakx merged commit da5ee73 into devlooped:main Jan 17, 2021
@stakx
Copy link
Contributor

stakx commented Jan 17, 2021

All good! 🚀 Thank you for contributing, @mujdatdinc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property indexers raises ' System.Reflection.AmbiguousMatchException: Ambiguous match found.' exception.
2 participants