Fix InvalidOperationException when mocking class with overloaded property/indexer in base class
#1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Apr 9, 2021
Comment on lines
+365
to
+373
| var parameterTypes = new ParameterTypes(property.GetIndexParameters()); | ||
| var derivedProperty = expression.Expression.Type | ||
| .GetMember(property.Name, MemberTypes.Property, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance) | ||
| .Cast<PropertyInfo>() | ||
| .SingleOrDefault(p => p.PropertyType == property.PropertyType); | ||
| .SingleOrDefault(p => | ||
| { | ||
| return p.PropertyType == property.PropertyType | ||
| && new ParameterTypes(p.GetIndexParameters()).CompareTo(parameterTypes, true, false); | ||
| }); |
There was a problem hiding this comment.
This could possibly be optimized further. Ideally, we'd avoid the calls to .GetIndexParameters(), as well as the comparison, by checking first whether both PropertyInfos are of the same type (property vs. indexer), and only doing the comparison when both are indexers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1153.