Should only add public interfaces

[scott-xu]

If the interface is not public, the castle dynamic proxy will throw:
Castle.DynamicProxy.Generators.GeneratorException : Type
System.Data.Entity.Internal.Linq.IInternalQueryAdapter is not visible to
DynamicProxy. Can not create proxy for types that are not accessible.
Make the type public, or internal and mark your assembly with [assembly:
InternalsVisibleTo(InternalsVisible.ToDynamicProxyGenAssembly2)]
attribute.

[scott-xu]

Hi @kzu , sorry to bother you again, the previous pull request #119 caused some breaking issues.

• If the interface is not public, the castle dynamic proxy will throw Type is not visible to DynamicProxy. This is caused by included non-public interfaces when generate proxies
• Issue85 FooTest broken. This is caused by method's declaring type changed to interface
• _326 ShouldSupportMockingWinFormsControl broken. This is caused by included COM interfaces when generate proxies which is not supported by castle dynamic proxy

This pull request fixed the issues listed above and passed all UT and also added 2 UTs. Could you please help take a look?

Thanks in advance!

[kzu]

Looks good. I guess it will be hard to let those that are InternalsVisibleTo go through still?

[kzu]

This condition makes my brain hurt :(. Not sure how to improve it significantly though :(

[scott-xu]

Probably it could: check the interface's assembly and see if the assembly has the corresponding attribute.

发自我的 iPhone

在 2014年8月7日，1:16，"Daniel Cazzulino" notifications@github.com 写道：

Looks good. I guess it will be hard to let those that are InternalsVisibleTo go through still?

—
Reply to this email directly or view it on GitHub.

[kzu]

That would be great :)
On Aug 6, 2014 10:12 PM, "Scott Xu" notifications@github.com wrote:

Probably it could: check the interface's assembly and see if the assembly
has the corresponding attribute.

发自我的 iPhone

在 2014年8月7日，1:16，"Daniel Cazzulino" notifications@github.com 写道：

Looks good. I guess it will be hard to let those that are
InternalsVisibleTo go through still?

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#123 (comment).