Migrate .NET Core projects to vs2017 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure in appveyor build is addressed by PR #335. |
Moq.NetCore.csproj remains an old PCL project. Bye-bye wrapped project! I don't miss you.
Remove the PCL project from Moq.sln, but didn't add the new one because the NuGet.Restore.targets doesn't handle the new project. When invoking `nuget.exe Restore Moq.sln`, nuget.exe tries to use MSBuild 14.0 which fails on the new .csproj.
jeremymeng
force-pushed
the
migrate-to-vs2017
branch
from
12fef2e
to
eac2f80
Compare
|
Looks great @jeremymeng ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kzu So far I've only converted the .NET Core projects to use the new .csproj format. There are too much magic in the MSBuild scripts for the Desktop .csproj's...will take more time and likely your help too :)