Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added overload to Verify to accept Times as a Method Group #34

Merged
merged 4 commits into from
Feb 28, 2013

Conversation

ChrisMissal
Copy link
Contributor

Here's the simple fix for this discussion:

https://groups.google.com/d/topic/moqdisc/PPBY1F-C-ME/discussion

Is this good enough, or is there more I need to do for this pull request?

@kalebpederson
Copy link
Collaborator

If we're going to add it I think we should add it to all the overloads, not just that one. For example, the following overload would should also support it:

void Verify(Expression<Action<T>> expression, Times times, string failMessage)

...there are probably others as well.

@kzu
Copy link
Contributor

kzu commented Feb 28, 2013

I'd love to see the additional overloads too!

@ChrisMissal
Copy link
Contributor Author

Wow, I totally forgot about this! My mistake, the remaining overloads have been added now.

kzu added a commit that referenced this pull request Feb 28, 2013
added overload to Verify to accept Times as a Method Group
@kzu kzu merged commit 6c4153e into devlooped:dev Feb 28, 2013
@kzu
Copy link
Contributor

kzu commented Feb 28, 2013

Awesome. Thanks Chris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants