Fix failing AppVeyor build #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One unit tests uses `System.IO.InternalBufferOverflowException` as a placeholder. This type does not exist in .NET Standard 1.3. The unit test can be safely rewritten to use a different exception; that should then fix the (currently failing) CI build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One unit tests uses
System.IO.InternalBufferOverflowExceptionas a placeholder. This type does not exist in .NET Standard 1.3 (it looks like it will be reintroduced with .NET Standard 2.0 in theSystem.IO.FileSystem.Watcherpackage) and so the .NET Standard build fails. This unit test can be safely rewritten to use a different exception type.