Ensure default mock names are (more) unique #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default mock object names are built from the type name and a hex number. Instead of building that number from the first 4 digits of a GUID, create 8 unique (but non-random) hex digits in the simplest possible way: using a thread-safe ever-increasing counter. It is still possible that the same number is used more than once, but this is now far less likely to happen in real-world scenarios: it would require the generation of more than 2^32 mock objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default mock object names are built from the type name and a hex number. Instead of building that number from the first 4 digits of a GUID — a whole GUID is in practice unique, but the same does not hold true for only 4 of its digits —, create 8 unique (but non-random) hex digits in the simplest possible way: using a thread-safe ever-increasing counter.
It is still possible that the same number is used more than once, but this is now far less likely to happen in real-world scenarios: it would require the generation of more than 232 mock objects.
This fixes #348.