Fix formatting inconsistencies for array values in MockException.Message #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
changed the title
stakx
force-pushed
the
missing-nulls-in-exception-message
branch
2 times, most recently
from
38adaa3
to
63b4a34
Compare
Two inconsistencies have been reported in how arrays and arrays con-
taining null references are reported in the "expected invocation" and
"performed invocations" part of a `MockException` message:
1. In "expected invocation", arrays are completely omitted in the
message.
2. In "performed invocations", null references are omitted in an
array value dump.
This commit fixes both issues, and additionally ensures that in case
of non-terminating or long sequences, only the first 10 elements are
printed and the rest gets abbreviated as ", ...".
stakx
force-pushed
the
missing-nulls-in-exception-message
branch
from
63b4a34
to
71ed2e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #321.
Two inconsistencies have been reported in how arrays and arrays containing null references are reported in the "expected invocation" and "performed invocations" part of a
MockExceptionmessage:In "expected invocation", arrays are completely omitted in the message.
In "performed invocations", null references are omitted in an array value dump.
This commit fixes both issues, and additionally ensures that in case of non-terminating or long sequences, only the first 10 elements are printed and the rest gets abbreviated as
", ...".