Fix mocking of redeclared interface methods #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 97a0f14 changed the behavior of `mock.SetupAllProperties` so that read-only properties could be mocked, too. At the same time, it broke the frequent use case where a read-only property in a base interface is redeclared as a read-write property in a derived inter- face. Those redeclared properties would no longer be mocked correctly. This commit reenables that scenario simply by changing the order in which properties are set up: properties in base interfaces (i.e. those furthest down the ancestor line) get set up before properties in more derived interfaces (i.e. those closer to the mocked type).
stakx
force-pushed
the
interface-method-overrides
branch
from
c043f8e
to
908e30e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #137 (commit 97a0f14) fixed a regression by changing the behavior of
mock.SetupAllPropertiesso that read-only properties could be mocked, too. At the same time, it broke the frequent use case where a read-only property in a base interface is redeclared as a read-write property in a derived interface. Those redeclared properties would no longer be mocked correctly.This commit reenables that scenario simply by changing the order in which properties are set up: properties in base interfaces (i.e. those furthest down the ancestor line) get set up before properties in more derived interfaces (i.e. those closer to the mocked type).
This fixes #162, #239, and #275.